[Enforced Digital Vouchers] - Attaching E-Documents when using Digital Vouchers by GMatuleviciute · Pull Request #29793 · microsoft/ALAppExtensions

GMatuleviciute · 2026-03-05T08:06:42Z

This pull request does not have a related issue as it's part of the delivery for development agreed directly with @altotovi @Groenbech96

Implementation

With this update enhanced automation for Digital Vouchers in sales and purchase document posting. When enabled, the system will automatically generate and attach E-Documents and related files to posted documents, streamlining document management and compliance.

Functional Changes

New Check Type Option

The Check Type field in the Digital Voucher Entry Setup table has been extended to include a new option: E-Document.
E-Document option is only valid when the Entry Type is set to Sales Document or Purchase Document.
The E-Document check type can only be selected when Generate Automatically is set to TRUE.

Automated Document Attachment on Posting

When posting sales or purchase documents, if setup is set to use E-Documents the system will attach related E-Document files to the Incoming Document Files of the posted sales/purchase document.

Impact

Reduces manual effort in attaching compliance documents.
Ensures all relevant files are consistently linked to posted documents.

Important

This Pull request related with microsoft/BCApps#7006

Fixes #

Introduces E-Document as a new check type for digital vouchers, enforcing automatic generation and linking for purchase documents. Updates UI logic to ensure consistent behavior and validation. Extends data structures and event handling to support E-Document attachment and integration with related processes. Enables more robust compliance with regulatory requirements for electronic document management.

Adds feature flag and setup validations before attaching digital vouchers to documents, ensuring attachments only occur when the functionality is enabled and properly configured. Expands handling for purchase credit memos and improves type checks for both sales and purchase documents.

Streamlines digital voucher validation by generalizing E-Document attachment to support more document types and rely on record references rather than hardcoded field access or document types. Improves maintainability and feature extensibility by extracting document details via a dedicated method and refining permission set object ordering. Enhances code clarity and robustness in preparation for feature expansion.

Introduces comprehensive automated tests covering E-Document attachment behavior for sales and purchase documents, ensuring correct enforcement and attachment logic. Updates dependency declarations for better test isolation, removes unused variables, and improves error checking and file name handling for E-Document processing. Enhances reliability and maintainability of digital voucher and E-Document integration.

…herEntrySetup.Table.al Co-authored-by: Grasiele Matuleviciute <131970463+GMatuleviciute@users.noreply.github.com>

Refactors E-Document file attachment for purchase documents by relocating the logic from the check codeunit to the main implementation codeunit, improving code structure and responsibility separation. Updates test object ranges, enhances test reliability, and adjusts error handling to use labels for better localization. Clarifies and simplifies validation around E-Document requirements and streamlines page variable initialization. Improves maintainability and prepares for future extensibility.

…implements "Digital Voucher Check"

github-actions · 2026-03-05T08:07:09Z

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

ventselartur · 2026-03-19T12:28:39Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

+        IncomingDocumentAttachment.SetRange("Posting Date", EDocument."Posting Date");
+        IncomingDocumentAttachment.SetContentFromBlob(TempBlob);
+        if not ImportAttachmentIncDoc.ImportAttachment(IncomingDocumentAttachment, StrSubstNo(FileNameTok, RecordLinkTxt), TempBlob) then
+            exit;


Add telemetry to see when we fail

ventselartur · 2026-03-19T12:30:00Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

+        IncomingDocumentAttachment.SetRange("Posting Date", PostingDate);
+        IncomingDocumentAttachment.SetContentFromBlob(TempBlob);
+        if not ImportAttachmentIncDoc.ImportAttachment(IncomingDocumentAttachment, FileName, TempBlob) then
+            exit;


ventselartur · 2026-03-19T12:30:16Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

+    begin
+        TempBlob.CreateInStream(PdfInStream);
+        if not PDFDocument.GetDocumentAttachmentStream(PdfInStream, ExtractedXmlBlob) then
+            exit;


ventselartur · 2026-03-19T12:30:27Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

        PurchCrMemoHeader: Record "Purch. Cr. Memo Hdr.";
+        PurchInvHeader: Record "Purch. Inv. Header";
        ReportSelections: Record "Report Selections";
+        SalesCrMemoHeader: Record "Sales Cr.Memo Header";
+        SalesInvHeader: Record "Sales Invoice Header";
+        ServCrMemoHeader: Record "Service Cr.Memo Header";
+        ServInvHeader: Record "Service Invoice Header";


Revert unnecessary changes

ventselartur · 2026-03-19T12:30:46Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

+        IncomingDocumentAttachment.Default := false;
+        IncomingDocumentAttachment."Main Attachment" := false;
+        if not ImportAttachmentIncDoc.ImportAttachment(IncomingDocumentAttachment, FileName, ExtractedXmlBlob) then
+            exit;


ventselartur · 2026-03-19T12:31:12Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

        ServCrMemoHeader: Record "Service Cr.Memo Header";
+        ServInvHeader: Record "Service Invoice Header";
        RecVar: Variant;


Revert unnecessary changes

ventselartur · 2026-03-19T12:31:28Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

@@ -653,8 +780,8 @@ codeunit 5579 "Digital Voucher Impl."
    [EventSubscriber(ObjectType::Table, Database::"Incoming Document", 'OnBeforeRemoveReferencedRecords', '', false, false)]
    local procedure CheckVoucherOnBeforeRemoveReferencedRecords(IncomingDocument: Record "Incoming Document"; var IsHandled: Boolean)
    var
-        RecRef: RecordRef;
        RelatedRecordID: RecordId;
+        RecRef: RecordRef;


Revert unnecessary change

ventselartur · 2026-03-19T12:35:01Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/VoucherAttachmentCheck.Codeunit.al

        if (DigitalVoucherEntryType in [DigitalVoucherEntryType::"General Journal", DigitalVoucherEntryType::"Purchase Journal", DigitalVoucherEntryType::"Sales Journal"]) or
           (RecRef.Number() = Database::"Service Header")
        then
-            error(NotPossibleToPostWithoutVoucherErr);


ventselartur · 2026-03-19T12:37:23Z

Apps/W1/EnforcedDigitalVouchers/test/src/EDocAttachmentTests.Codeunit.al

+        if EDocument."Entry No" <> 0 then begin
+            EDocument."Document No." := PurchaseHeader."No.";
+            EDocument."Posting Date" := PurchaseHeader."Posting Date";
+            EDocument."Document Record ID" := PurchaseHeader.RecordId();
+            EDocument.Modify(false);
+        end;


Let's avoid IF statements in tests if possible as it make it harded to read. Can we split this procedure into two, one only create the purchase header and the other do both. The latter will call the first one to remove duplicatio.

Improves observability by logging errors via feature telemetry when e-document attachment operations fail, including XML extraction from PDFs and incoming document imports. This helps diagnose issues in production without relying solely on user-reported errors. Refactors a purchase document test helper to separate the case where no e-document link is needed, removing an unnecessary guard condition and simplifying the overload that requires an e-document record. Also includes minor code style normalizations (variable reordering, lowercase `error()` calls) for consistency.

AndriusAndrulevicius

Comments resolved

AndriusAndrulevicius · 2026-03-23T09:59:44Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

+        IncomingDocumentAttachment.SetRange("Posting Date", EDocument."Posting Date");
+        IncomingDocumentAttachment.SetContentFromBlob(TempBlob);
+        if not ImportAttachmentIncDoc.ImportAttachment(IncomingDocumentAttachment, StrSubstNo(FileNameTok, RecordLinkTxt), TempBlob) then
+            exit;


AndriusAndrulevicius · 2026-03-23T09:59:54Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

+        IncomingDocumentAttachment.SetRange("Posting Date", PostingDate);
+        IncomingDocumentAttachment.SetContentFromBlob(TempBlob);
+        if not ImportAttachmentIncDoc.ImportAttachment(IncomingDocumentAttachment, FileName, TempBlob) then
+            exit;


AndriusAndrulevicius · 2026-03-23T09:59:58Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

+    begin
+        TempBlob.CreateInStream(PdfInStream);
+        if not PDFDocument.GetDocumentAttachmentStream(PdfInStream, ExtractedXmlBlob) then
+            exit;


AndriusAndrulevicius · 2026-03-23T10:00:02Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

+        IncomingDocumentAttachment.Default := false;
+        IncomingDocumentAttachment."Main Attachment" := false;
+        if not ImportAttachmentIncDoc.ImportAttachment(IncomingDocumentAttachment, FileName, ExtractedXmlBlob) then
+            exit;


AndriusAndrulevicius · 2026-03-23T10:00:37Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

        PurchCrMemoHeader: Record "Purch. Cr. Memo Hdr.";
+        PurchInvHeader: Record "Purch. Inv. Header";
        ReportSelections: Record "Report Selections";
+        SalesCrMemoHeader: Record "Sales Cr.Memo Header";
+        SalesInvHeader: Record "Sales Invoice Header";
+        ServCrMemoHeader: Record "Service Cr.Memo Header";
+        ServInvHeader: Record "Service Invoice Header";


AndriusAndrulevicius · 2026-03-23T10:00:42Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

        ServCrMemoHeader: Record "Service Cr.Memo Header";
+        ServInvHeader: Record "Service Invoice Header";
        RecVar: Variant;


AndriusAndrulevicius · 2026-03-23T10:00:46Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

@@ -653,8 +780,8 @@ codeunit 5579 "Digital Voucher Impl."
    [EventSubscriber(ObjectType::Table, Database::"Incoming Document", 'OnBeforeRemoveReferencedRecords', '', false, false)]
    local procedure CheckVoucherOnBeforeRemoveReferencedRecords(IncomingDocument: Record "Incoming Document"; var IsHandled: Boolean)
    var
-        RecRef: RecordRef;
        RelatedRecordID: RecordId;
+        RecRef: RecordRef;


AndriusAndrulevicius · 2026-03-23T10:00:49Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/VoucherAttachmentCheck.Codeunit.al

        if (DigitalVoucherEntryType in [DigitalVoucherEntryType::"General Journal", DigitalVoucherEntryType::"Purchase Journal", DigitalVoucherEntryType::"Sales Journal"]) or
           (RecRef.Number() = Database::"Service Header")
        then
-            error(NotPossibleToPostWithoutVoucherErr);


AndriusAndrulevicius · 2026-03-23T10:00:56Z

Apps/W1/EnforcedDigitalVouchers/test/src/EDocAttachmentTests.Codeunit.al

+        if EDocument."Entry No" <> 0 then begin
+            EDocument."Document No." := PurchaseHeader."No.";
+            EDocument."Posting Date" := PurchaseHeader."Posting Date";
+            EDocument."Document Record ID" := PurchaseHeader.RecordId();
+            EDocument.Modify(false);
+        end;


ventselartur · 2026-03-26T10:40:19Z

Apps/W1/EnforcedDigitalVouchers/app/Permissions/DigitalVoucherObjects.PermissionSet.al

+                  codeunit "Digital Voucher Entry" = X,
+                  codeunit "Digital Voucher Feature" = X,
+                  codeunit "Digital Voucher Impl." = X,
                  codeunit "Voucher Attachment Check" = X,
+                  codeunit "Voucher Attach Or Note Check" = X,
+                  codeunit "Voucher E-Document Check" = X,
                  codeunit "Voucher No Check" = X,
                  codeunit "Voucher Unknown Check" = X,
-                  codeunit "Digital Voucher Impl." = X,
-                  codeunit "Digital Voucher Feature" = X,
-                  codeunit "Digital Voucher Entry" = X;
+                  page "Digital Voucher Entry Setup" = X,
+                  page "Digital Voucher Guide" = X,
+                  page "Digital Voucher Setup" = X,
+                  page "Voucher Entry Source Codes" = X;


Revert unnecessary changes related to ordering

ventselartur · 2026-03-26T10:40:32Z

Apps/W1/EnforcedDigitalVouchers/app/src/EntrySetup/DigitalVoucherEntrySetup.Table.al

        }
    }
-}
+}


Revert unnecessary change in the last line

ventselartur · 2026-03-26T10:42:08Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

+        IncomingDocumentAttachment.SetRange("Posting Date", EDocument."Posting Date");
+        IncomingDocumentAttachment.SetContentFromBlob(TempBlob);
+        if not ImportAttachmentIncDoc.ImportAttachment(IncomingDocumentAttachment, StrSubstNo(FileNameTok, RecordLinkTxt), TempBlob) then begin
+            FeatureTelemetry.LogError('', 'E-Documents', 'AttachIncomingEDocument', GetLastErrorText(true), GetLastErrorCallStack());


We cannot write the error text and erros tack to telemetry as it may potentially contain the customer data. Just have hardcoded lines there - "Cannot import attachment" or something like that. We will be able to find the error by telemetry tag, so the text won't add much value.

ventselartur · 2026-03-26T10:42:44Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

+        IncomingDocumentAttachment.SetRange("Posting Date", PostingDate);
+        IncomingDocumentAttachment.SetContentFromBlob(TempBlob);
+        if not ImportAttachmentIncDoc.ImportAttachment(IncomingDocumentAttachment, FileName, TempBlob) then begin
+            FeatureTelemetry.LogError('', 'E-Documents', 'AttachPurchaseEDocument', GetLastErrorText(true), GetLastErrorCallStack());


Do not write error text and call stack to telemetry, only hardcoded text

ventselartur · 2026-03-26T10:43:09Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

+    begin
+        TempBlob.CreateInStream(PdfInStream);
+        if not PDFDocument.GetDocumentAttachmentStream(PdfInStream, ExtractedXmlBlob) then begin
+            FeatureTelemetry.LogError('', 'E-Documents', 'ExtractXMLFromPDF', GetLastErrorText(true), GetLastErrorCallStack());


Replace with hardcoded text to avoid writing customer data to telemetry

ventselartur · 2026-03-26T10:43:27Z

Apps/W1/EnforcedDigitalVouchers/app/src/Implementation/DigitalVoucherImpl.Codeunit.al

+        IncomingDocumentAttachment.Default := false;
+        IncomingDocumentAttachment."Main Attachment" := false;
+        if not ImportAttachmentIncDoc.ImportAttachment(IncomingDocumentAttachment, FileName, ExtractedXmlBlob) then begin
+            FeatureTelemetry.LogError('', 'E-Documents', 'ExtractXMLFromPDF', GetLastErrorText(true), GetLastErrorCallStack());


ventselartur · 2026-03-26T10:44:22Z

Apps/W1/EnforcedDigitalVouchers/test/app.json

    "TranslationFile"
  ]
-}
+}


Revert unnecessary change in the last line

ventselartur · 2026-03-26T10:44:34Z

Apps/W1/EnforcedDigitalVouchers/app/app.json

  "application": "29.0.0.0",
  "target": "Cloud"
-}
+}


Revert the change for the last line

AndriusAndrulevicius and others added 13 commits February 23, 2026 12:54

Update Apps/W1/EnforcedDigitalVouchers/app/src/EntrySetup/DigitalVouc…

7e36e80

…herEntrySetup.Table.al Co-authored-by: Grasiele Matuleviciute <131970463+GMatuleviciute@users.noreply.github.com>

Update Apps/W1/EnforcedDigitalVouchers/app/src/EntrySetup/DigitalVouc…

9d7535b

…herEntrySetup.Table.al Co-authored-by: Grasiele Matuleviciute <131970463+GMatuleviciute@users.noreply.github.com>

Merge branch 'main' into dev/aan/digitalvoucher

597bf71

Revert Digital Voucher Entry Setup changes

8b9bd7d

revert Digital Voucher Entry Setup changes

5264655

Structure of codeunit 5579 "Digital Voucher Impl." update

acc7cb2

Removed unnessasary empty line

c035881

Updated sequence of code in codeunit 5588 "Voucher E-Document Check" …

30dc167

…implements "Digital Voucher Check"

GMatuleviciute requested a review from a team as a code owner March 5, 2026 08:06

GMatuleviciute requested a review from alexei-dobriansky March 5, 2026 08:06

GMatuleviciute mentioned this pull request Mar 5, 2026

[E-Documents Core] - Events for attaching E-Documents when using Digital Vouchers microsoft/BCApps#7006

Open

JesperSchulz added the Integration GitHub request for Integration area label Mar 5, 2026

ventselartur reviewed Mar 19, 2026

View reviewed changes

ventselartur requested changes Mar 19, 2026

View reviewed changes

AndriusAndrulevicius reviewed Mar 23, 2026

View reviewed changes

ventselartur reviewed Mar 26, 2026

View reviewed changes

add telemetry tags

6bd3ee1

                       }
                   }
-              }
+              }

                
                    No newline at end of file

Conversation

GMatuleviciute commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndriusAndrulevicius left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

GMatuleviciute commented Mar 5, 2026 •

edited

Loading