-
Notifications
You must be signed in to change notification settings - Fork 696
Added dimension setup & posted entries for fixed assets #29390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tuan-nguyen-fenwick
wants to merge
26
commits into
microsoft:main
Choose a base branch
from
tuan-nguyen-fenwick:uptake/fixed-asset-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
2879ddb
Added dimension setup to fixed assets
e4c3ea2
Added InsertFixedAsset function that takes FA Posting Group parameter
122e0f8
Added FA posting group to fixed asset dataset
b183a44
Added codeunits to generate FA journal lines & posted entries
63d9a69
Merged PR 38641: Dimension setup & posted entries for Fixed Assets
1b8a435
Sorted variables and usings
36102d0
Merge remote-tracking branch 'origin/main' into uptake/fixed-asset-up…
7cf988d
Updated Fixed Asset object IDs
1d4ce41
Added GetCashAccountNo function
a66dec4
Updated FA journal lines creation
b03351a
Implemented Cash account for fixed asset acquisitions in CZ
2421faf
Added CreateFAJournalSetups function
3c9f7c9
Implemented Cash account for fixed asset acquisitions in DK
8f5845d
Implemented Cash account for fixed asset acquisitions in NL
6620676
Corrected namespace reference for codeunit "Create NL GL Accounts"
9e69bb1
Merge remote-tracking branch 'origin/main' into uptake/fixed-asset-up…
e7b5230
Updated G/L account used to acquire fixed assets in DK
30f4605
Moved FA journal lines coduenit to Historical folder
1b2b9f9
Moved InsertFAGenJournalLine function to Contoso FA codeunit
12b4c58
Merge remote-tracking branch 'origin/main' into uptake/fixed-asset-up…
83304f1
Replaced GetCashAccountNo by Cash account directly for W1
68eacee
Removed GetCashAccountNo function & OnBeforeGetCashAccountForFixedAss…
ef62bbc
Removed OnBeforeGetCashAccountForFixedAssetAcquisition subscriber fro…
59f2c70
Added OnBeforeInsertGenJournalLineCZ subscriber to populate Cash acco…
88c2279
Replaced OnBeforeInsertGenJournalLine subscriber to populate Cash acc…
4f9766c
Replaced OnBeforeInsertGenJournalLine subscriber to populate Cash acc…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
...offeeDemoDataset/app/DemoData/FixedAsset/2.Master Data/CreateFADimensionValue.Codeunit.al
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // ------------------------------------------------------------------------------------------------ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
| // ------------------------------------------------------------------------------------------------ | ||
|
|
||
| namespace Microsoft.DemoData.FixedAsset; | ||
|
|
||
| using Microsoft.DemoData.Finance; | ||
| using Microsoft.DemoTool.Helpers; | ||
| using Microsoft.Finance.Dimension; | ||
| using Microsoft.FixedAssets.FixedAsset; | ||
|
|
||
| codeunit 5614 "Create FA Dimension Value" | ||
| { | ||
| InherentEntitlements = X; | ||
| InherentPermissions = X; | ||
|
|
||
| trigger OnRun() | ||
| var | ||
| ContosoDimension: Codeunit "Contoso Dimension"; | ||
| CreateDimension: Codeunit "Create Dimension"; | ||
| CreateDimensionValue: Codeunit "Create Dimension Value"; | ||
| CreateFixedAsset: Codeunit "Create Fixed Asset"; | ||
| begin | ||
| ContosoDimension.InsertDefaultDimensionValue(Database::"Fixed Asset", CreateFixedAsset.FA000010(), CreateDimension.DepartmentDimension(), CreateDimensionValue.AdministrationDepartment(), Enum::"Default Dimension Value Posting Type"::" "); | ||
| ContosoDimension.InsertDefaultDimensionValue(Database::"Fixed Asset", CreateFixedAsset.FA000020(), CreateDimension.DepartmentDimension(), CreateDimensionValue.AdministrationDepartment(), Enum::"Default Dimension Value Posting Type"::" "); | ||
| ContosoDimension.InsertDefaultDimensionValue(Database::"Fixed Asset", CreateFixedAsset.FA000030(), CreateDimension.DepartmentDimension(), CreateDimensionValue.ProductionDepartment(), Enum::"Default Dimension Value Posting Type"::" "); | ||
| ContosoDimension.InsertDefaultDimensionValue(Database::"Fixed Asset", CreateFixedAsset.FA000040(), CreateDimension.DepartmentDimension(), CreateDimensionValue.ProductionDepartment(), Enum::"Default Dimension Value Posting Type"::" "); | ||
| ContosoDimension.InsertDefaultDimensionValue(Database::"Fixed Asset", CreateFixedAsset.FA000050(), CreateDimension.DepartmentDimension(), CreateDimensionValue.ProductionDepartment(), Enum::"Default Dimension Value Posting Type"::" "); | ||
| ContosoDimension.InsertDefaultDimensionValue(Database::"Fixed Asset", CreateFixedAsset.FA000060(), CreateDimension.DepartmentDimension(), CreateDimensionValue.ProductionDepartment(), Enum::"Default Dimension Value Posting Type"::" "); | ||
| ContosoDimension.InsertDefaultDimensionValue(Database::"Fixed Asset", CreateFixedAsset.FA000070(), CreateDimension.DepartmentDimension(), CreateDimensionValue.ProductionDepartment(), Enum::"Default Dimension Value Posting Type"::" "); | ||
| ContosoDimension.InsertDefaultDimensionValue(Database::"Fixed Asset", CreateFixedAsset.FA000080(), CreateDimension.DepartmentDimension(), CreateDimensionValue.ProductionDepartment(), Enum::"Default Dimension Value Posting Type"::" "); | ||
| ContosoDimension.InsertDefaultDimensionValue(Database::"Fixed Asset", CreateFixedAsset.FA000090(), CreateDimension.DepartmentDimension(), CreateDimensionValue.AdministrationDepartment(), Enum::"Default Dimension Value Posting Type"::" "); | ||
| end; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those individual events will soon make the codebase difficult to maintain, to see how we localize GL accounts, see the coding patterns in this file (under the section GL Account):
https://github.com/microsoft/ALAppExtensions/blob/main/Apps/W1/ContosoCoffeeDemoDataset/app/Coding-Patterns.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I've restructured and changed to using more generic event OnBeforeInsertEvent for CZ, NL and DK instead of relying on a custom event.