Move admin center / publish to env authentication to action rather than inline powershell#2116
Open
aholstrup1 wants to merge 3 commits intomainfrom
Open
Move admin center / publish to env authentication to action rather than inline powershell#2116aholstrup1 wants to merge 3 commits intomainfrom
aholstrup1 wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #2113 where the "Create Online Dev. Environment" and "Publish to Environment" workflows fail when no AuthContext is provided due to missing DebugLogHelper imports. The solution extracts inline PowerShell authentication logic into a new reusable AL-Go action called CheckAuthContext, which is invoked using Invoke-AlGoAction.ps1 to ensure proper module imports.
Changes:
- Created new CheckAuthContext action to handle authentication context verification and device code flow initialization
- Updated CreateOnlineDevelopmentEnvironment and PublishToEnvironment workflows to use the new action
- Added comprehensive unit tests for the new action
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Actions/CheckAuthContext/CheckAuthContext.ps1 | Core script that checks for auth secrets and initiates device code flow if needed |
| Actions/CheckAuthContext/action.yaml | Action definition with inputs and outputs, invokes script via Invoke-AlGoAction.ps1 |
| Actions/CheckAuthContext/README.md | Documentation for the new action including inputs, outputs, and usage |
| Tests/CheckAuthContext.Action.Test.ps1 | Comprehensive unit tests covering secret discovery, fallback logic, and device login scenarios |
| RELEASENOTES.md | Added issue #2113 to release notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rup/inlinepowershell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❔What, Why & How
Problem
Right now, the "Publish to Environment" and "Create Online Dev. Environment" workflows will fail when no Authcontext is provided. AL-Go is supposed to use the DeviceCode flow when we're lacking an Authcontext but in order to run DownloadAndImportBcContainerHelper we need to import the DebugHelper.psm1. Right now we don't, so we see failures around "OutputDebug" not being recognized.
Proposed Solution
Both workflow use an inline powershell script. We could move this to its own AL-Go action where the script is invoked with Invoke-AlGoAction.ps1. That way we ensure that DebugLogHelper is imported.
Related to issue: #2113
✅ Checklist