[WIP]: Fix kindnet POD_SUBNET mismatch in CNCF conformance tests#198
[WIP]: Fix kindnet POD_SUBNET mismatch in CNCF conformance tests#198kasturinarra wants to merge 1 commit intomicroshift-io:mainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0fa9e00 to
5a6cbae
Compare
| echo " - Waiting for kindnet rollout to complete" | ||
| make env CMD="kubectl -n kube-kindnet rollout status daemonset/kube-kindnet-ds --timeout=120s" | ||
| fi | ||
| echo " ✓ kindnet POD_SUBNET configured correctly" |
There was a problem hiding this comment.
If this works, we should probably update the microshift-io/src/kindnet/assets/kindnet/04-daemonset.yaml file from microshift-io/src/kindnet/generate_manifests.sh
There was a problem hiding this comment.
Agree... unfortunately still not working...i see 3 tests are still failing.. Need to look into logs on why...
06eea11 to
17e7f22
Compare
17e7f22 to
72fc6f9
Compare
No description provided.