Fix MCS disconnects on aggressive OEM process managers#3667
Open
areteruhiro wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the long-lived MCS connection in a foreground service even when the app is exempt from battery optimizations.
Problem
On a Xiaomi device, Cloud Messaging connected briefly and then immediately returned to the disconnected state. The device log showed Xiaomi's low-memory killer terminating the persistent process within seconds:
The current
ForegroundServiceContextskips foreground-service mode whenPowerManager.isIgnoringBatteryOptimizations()returnstrue. On this device, the battery exemption did not prevent the OEM process manager from assigning the persistent process a cached OOM score and killing it.Once the persistent process was killed, the MCS socket disappeared and Cloud Messaging reported that it was disconnected.
Changes
forceForegroundmode toForegroundServiceContext.Verification
:play-services-core:assembleMapboxDefaultDebug --no-daemon --no-configuration-cache --max-workers=1ForegroundServiceContext.javaandTriggerReceiver.java.