[BOUNTY #2994] Preserve phone hints in RCS sync requests#3476
Open
mt211211 wants to merge 40 commits into
Open
[BOUNTY #2994] Preserve phone hints in RCS sync requests#3476mt211211 wants to merge 40 commits into
mt211211 wants to merge 40 commits into
Conversation
|
So LLMs have devolved into just yoinking code adding like 2 changes then trying to claim the bounty for it? Wtf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #2994
This is a stacked follow-up on top of the active RCS/Constellation implementation in #3359. It is not intended to supersede that work; it isolates a small provisioning edge case from the latest #2994 logcat discussion so it can be reviewed or cherry-picked.
Focused change in the final commit:
Why this matters:
The current live-device logs moved past IID token acquisition but still showed provisioning failing around verifyPhoneNumber, followed by Google Messages reporting that no phone number was found for the provisioning id. Sending an empty sim_readable_number after formatting failure loses useful caller-provided phone data. This patch preserves that data while still preferring normalized E.164 when available.
Validation:
Maintainer note: if a full duplicate stacked PR is noisy, the intended cherry-pick is the last commit only: 2efd1bc (Handle RCS sync request phone fallbacks).