Skip to content

Fido: Fix PIN requirement for USB plugged after navigating to USB view #3462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
p1gp1g wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fido: Fix PIN requirement for USB plugged after navigating to USB view #3462

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c7f04f
Fix PIN requirement for USB plugged after navigating to USB view
p1gp1g May 11, 2026
de0aaeb
Fido: Throw Ctap2StatusException with USB to pass error to activity
p1gp1g May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...s-fido/core/src/main/kotlin/org/microg/gms/fido/core/transport/usb/UsbTransportHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import kotlinx.coroutines.CancellationException
import kotlinx.coroutines.CompletableDeferred
import org.microg.gms.fido.core.*
import org.microg.gms.fido.core.transport.AuthenticatorResponseWithUser
import org.microg.gms.fido.core.transport.Ctap2StatusException
import org.microg.gms.fido.core.transport.Transport
import org.microg.gms.fido.core.transport.TransportHandler
import org.microg.gms.fido.core.transport.TransportHandlerCallback
Expand Down Expand Up @@ -155,7 +156,9 @@ class UsbTransportHandler(private val context: Context, callback: TransportHandl
throw e
} catch (e: WrongPinException) {
throw e
} catch (e: Exception) {
} catch (e: Ctap2StatusException) {
throw e
} catch (e: Exception) {
Log.w(TAG, e)
}
}
Expand All @@ -167,6 +170,12 @@ class UsbTransportHandler(private val context: Context, callback: TransportHandl
return handle(options, callerPackage, device, iface, pinRequested, pin)
} catch (e: CancellationException) {
throw e
} catch (e: MissingPinException) {
throw e
} catch (e: WrongPinException) {
throw e
} catch (e: Ctap2StatusException) {
throw e
} catch (e: Exception) {
Log.w(TAG, e)
}
Expand Down