microG Settings integration, icon/activity changes#1191
microG Settings integration, icon/activity changes#1191Nanolx wants to merge 7 commits intomicrog:masterfrom
Conversation
…out breaking microG functionality. - Think of launchers that can't hide apps, so you need to disable the launcher activity in order to hide it. - Also useful when microG is embedded inside System Settings, and you want to disable the launcher icon. - Could in theory be used in the future for a feature "hide app icon" inside microG settings itself
…1 (SDK 23,24,25) - correct category for System Settings embedding
| <!-- Separate launcher icon from main activity so it can be disabled manualy --> | ||
| <!-- microG Settings activity-alias shown in Launcher --> | ||
| <activity-alias | ||
| android:enabled="true" |
There was a problem hiding this comment.
It will be interesting to try something like this:
android:enabled="@bool/is_alias_enabled"
then add <bool name="is_alias_enabled">true</bool> to bools.xml
and create ../values-v23/bools.xml with this
<?xml version="1.0" encoding="utf-8"?>
<!--
~ Copyright (C) 2020 microG Project Team
~
~ Licensed under the Apache License, Version 2.0 (the "License");
~ you may not use this file except in compliance with the License.
~ You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
-->
<resources>
<bool name="is_alias_enabled">false</bool>
</resources>
So launcher icon should be always disabled Android 6.0 and newer.
Settings integration is available starting from this android version.
There was a problem hiding this comment.
So launcher icon should be always disabled Android 6.0 and newer. Settings integration is available starting from this android version.
Honeslty I think that can be still visible, is a shortcut, wothout go on settings>system>microg.
For the same reason I have installed an app to open update on lineageos.
|
Hello @Nanolx Maybe you can find time to update this pull request? |
|
I'll have a look at it next week. |
|
Did this slip through the cracks? This would be super nice to have 👀 |
ae17355 to
8078073
Compare
|
@Nanolx, I don't know if you're free to be able to look into this right now or not. But if possible, it'll be much appreciated. Sorry if I bothered you. |
|
This PR is obsolete because most of its stuff is already merged separately in microG. |
|
How I have said "most of its stuff is already merged separately in microG" but probably there is still a small part that isn't, but it need to adapted to the latest code of microG and I don't have time currently. About #1489 probably yes since the icon of microG got changed in the meantine but I don't have time to check carefully the PR now. |
Follow up for #765