Upgrade to current Bootstrap - brings small design changes#22
Open
Zegnat wants to merge 7 commits into
Open
Conversation
Co-Authored-By: Brian Tremblay <dev@btrem.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the template uses an old alpha version of Bootstrap 4. It does not make sense to be using an alpha version at all. Bootstrap 5 had its first release 2021-05-05, maybe it is time to make the step 5+ years later. This PR does a few things:
<section>does not make sense.titleattribute and into an associate visible text instead.As an aside I have also tweaked some inaccuracies in the README that were just never updated, like the move from the indieweb org to the microformats org. Happy to split that commit into a separate PR if it turns out this PR stalls.
Comparison