ef: Improve parse error messages with context, caret, and field hints#14
Open
ef: Improve parse error messages with context, caret, and field hints#14
Conversation
Replace the unhelpful "Parse error! arg# N out of M" with structured diagnostics on stderr: error headline identifying the bad token and which header it was expected in, the full command with a caret pointing to the exact token, and a list of valid fields when applicable. A global parse_err_ctx_t side-channel records context during parsing so the top-level error reporter can produce accurate messages without changing any parser function signatures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FRAME-SPEC parse errors are not so easy to read. This changes the parse errors to a more human friendly format:
Replace the unhelpful "Parse error! arg# N out of M" with structured diagnostics on stderr: error headline identifying the bad token and which header it was expected in, the full command with a caret pointing to the exact token, and a list of valid fields when applicable.
A global parse_err_ctx_t side-channel records context during parsing so the top-level error reporter can produce accurate messages without changing any parser function signatures.