Skip to content

Don't check board version if device is not connected #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
microbit-matt-hillsdon merged 1 commit into from
Apr 30, 2026
Merged

Don't check board version if device is not connected #1240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/editor/codemirror/language-server/diagnostics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import * as LSP from "vscode-languageserver-protocol";
import { Action, Diagnostic } from "../lint/lint";
import { positionToOffset } from "./positions";
import { MicrobitUSBConnection } from "@microbit/microbit-connection/usb";
import { ConnectionStatus } from "@microbit/microbit-connection";

const reportMicrobitVersionApiUnsupported =
"reportMicrobitVersionApiUnsupported";
Expand All @@ -32,7 +33,9 @@ export const diagnosticsMapping = (
// and warnOnV2OnlyFeatures setting is on.
if (
code === reportMicrobitVersionApiUnsupported &&
(!warnOnV2OnlyFeatures || device.getBoardVersion() !== "V1")
(!warnOnV2OnlyFeatures ||
device.status !== ConnectionStatus.Connected ||
device.getBoardVersion() !== "V1")
) {
return undefined;
}
Expand Down
Loading