Skip to content

Fix flashing over a program without partial flashing service #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
microbit-matt-hillsdon merged 4 commits into from
Feb 27, 2026
Merged

Fix flashing over a program without partial flashing service #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f08ed9
Attempt full flash if pf characteristic is not found.
microbit-grace Feb 16, 2026
5329580
Catch and skip resetting of device operation if pf characteristic is …
microbit-grace Feb 16, 2026
b8d895a
Merge branch 'apps' into flashover-cpp
microbit-matt-hillsdon Feb 27, 2026
102f04c
refactor: extract isCharacteristicNotFoundError and fix connect flow
microbit-matt-hillsdon Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions packages/microbit-connection/src/bluetooth-device-wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,13 @@ import {
DeviceBondState,
} from "./device-bond-state.js";

/**
* The @capacitor-community/bluetooth-le plugin throws this message when
* a characteristic UUID is not found in the device's GATT table.
*/
export const isCharacteristicNotFoundError = (e: unknown): boolean =>
e instanceof Error && e.message === "Characteristic not found.";

export const bondingTimeoutInMs = 40_000;
export const connectTimeoutInMs = 10_000;
export const scanningTimeoutInMs = 10_000;
Expand Down Expand Up @@ -479,14 +486,24 @@ export class BluetoothDeviceWrapper implements Logging {

await this.connectInternal();

progress(ProgressStage.ResettingDevice);
this.log("Resetting to pairing mode");
const pf = new PartialFlashingService(this);
await pf.resetToMode(MicroBitMode.Pairing);
await this.waitForDisconnect(10_000);
try {
progress(ProgressStage.ResettingDevice);
this.log("Resetting to pairing mode");
const pf = new PartialFlashingService(this);
await pf.resetToMode(MicroBitMode.Pairing);
await this.waitForDisconnect(10_000);

progress(ProgressStage.Connecting);
await this.connectInternal();
progress(ProgressStage.Connecting);
await this.connectInternal();
} catch (e) {
if (isCharacteristicNotFoundError(e)) {
this.log(
"Partial flashing characteristic not found, skipping reset.",
);
} else {
throw e;
}
}
}
this.log(`Connection ready; took ${Date.now() - startTime}`);
}
Expand Down
8 changes: 7 additions & 1 deletion packages/microbit-connection/src/flashing/flashing-partial.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import MemoryMap from "nrf-intel-hex";
import { BluetoothDeviceWrapper } from "../bluetooth-device-wrapper.js";
import {
BluetoothDeviceWrapper,
isCharacteristicNotFoundError,
} from "../bluetooth-device-wrapper.js";
import {
MicroBitMode,
PacketState,
Expand Down Expand Up @@ -47,6 +50,9 @@ const partialFlash = async (
);
} catch (e) {
connection.error("Partial flash failed", e);
if (isCharacteristicNotFoundError(e)) {
return PartialFlashResult.AttemptFullFlash;
}
if (
// Error thrown in iOS only for when user cancels the pairing dialog.
e instanceof Error &&
Expand Down