Skip to content

fix highlighter bugs - #4022

Open
redsti-github wants to merge 1 commit into
micro-editor:masterfrom
redsti-github:fix/highlight
Open

fix highlighter bugs#4022
redsti-github wants to merge 1 commit into
micro-editor:masterfrom
redsti-github:fix/highlight

Conversation

@redsti-github

Copy link
Copy Markdown

(new PR since i accidentally closed the old one (#4020), sorry)

 - patterns within regions no longer fail on certain line lengths and columns (micro-editor#4018)
 - region applies patterns before next nested region
@Neko-Box-Coder

Neko-Box-Coder commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@JoeKar

Hey, I think it will be great to get this reviewed and merged because I am seeing this problem manifests on a regular basis, and also considering it seems like #3127 is not going to be completed anytime soon.

@JoeKar

JoeKar commented Aug 2, 2026

Copy link
Copy Markdown
Member

If it doesn't break anything else then yes.

@Neko-Box-Coder

Copy link
Copy Markdown
Contributor

@JoeKar

Okay, I will try daily driving this and see how it goes.

Sorry to nag but would be great if you can take a look at #4028 when you are free as I have daily driven/tested it for a month and seems good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants