Open
Conversation
michalkvasnicak
requested changes
Mar 14, 2021
Owner
michalkvasnicak
left a comment
michalkvasnicak
left a comment
There was a problem hiding this comment.
@tbehrsin could you please:
- add some tests
- rebase and provide the same functionality for new DynamoDBRangeSubscriptionManager
?
Also if client unsubscribes from some subscription (GQL_STOP event) shouldn't we call return() too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In relation to issue #130 enable
AsyncIterator.return()on client disconnect by passing backISubscriber[]fromunsubscribeAllByConnectionIdand in turnconnectionManager.unregisterConnection.