Adding a code based feature flag to the demo#53
Open
JeremyCarlsten wants to merge 2 commits intomichaeltaranto:masterfrom
Open
Adding a code based feature flag to the demo#53JeremyCarlsten wants to merge 2 commits intomichaeltaranto:masterfrom
JeremyCarlsten wants to merge 2 commits intomichaeltaranto:masterfrom
Conversation
meetbryce
approved these changes
Apr 20, 2017
meetbryce
left a comment
meetbryce
left a comment
There was a problem hiding this comment.
Looks great. It's basically just a documentation update and an example being added to the demo.
Author
|
Yep nothing really difficult. Just wanted to share how we were doing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We needed to feature flag in an angular controller, not an element on the view. I figured out how to do this so I decided to update your readme and demo.