Skip to content

Do not require ingress-controller for Gardener setup. - #325

Open
Gerrit91 wants to merge 12 commits into
masterfrom
remove-gardener-ingress
Open

Do not require ingress-controller for Gardener setup.#325
Gerrit91 wants to merge 12 commits into
masterfrom
remove-gardener-ingress

Conversation

@Gerrit91

@Gerrit91 Gerrit91 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description

Follow-up of #299.

Used AI-Tools ✨

  • deepseek-v4-flash-0731 for the mutating webhook

@Gerrit91

Copy link
Copy Markdown
Contributor Author

/cc @l0wl3vel

@l0wl3vel l0wl3vel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Draft PR containing my suggested improvements: #327

Yeah, the workarounds for kind-ccm suck. Realistically we should just switch to metallb/kubevip and use APR advertisements directly into the mini-lab_internal network to create load balancers. I think we even did that for kamaji-lab.

kind-ccm which was kind of difficult to integrate in the first place, so metallb is worth a shot imo.

The custom Go webhook was wild either way😅

Comment thread webhook/webhook Outdated
Comment thread webhook/main.go Outdated
Comment thread deploy_monitoring.yaml
Comment thread compose.yaml Outdated
@github-project-automation github-project-automation Bot moved this to In Progress in Development Aug 24, 2026
@Gerrit91

Copy link
Copy Markdown
Contributor Author

Cool. Thanks for taking look. I think I am fine with the proposals and would like to merge them into this PR?

@l0wl3vel

Copy link
Copy Markdown
Contributor

Sure think, you are welcome. Cherry picked them over. Please squash merge the PR to prevent dragging in the 40MB removed webhook binary

@Gerrit91
Gerrit91 force-pushed the remove-gardener-ingress branch from 96d7212 to 9a6434e Compare August 24, 2026 09:00
@l0wl3vel
l0wl3vel self-requested a review August 24, 2026 09:18

@l0wl3vel l0wl3vel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants