Do not require ingress-controller for Gardener setup. - #325
Open
Gerrit91 wants to merge 12 commits into
Open
Conversation
Contributor
Author
|
/cc @l0wl3vel |
l0wl3vel
requested changes
Aug 24, 2026
l0wl3vel
left a comment
Contributor
There was a problem hiding this comment.
Draft PR containing my suggested improvements: #327
Yeah, the workarounds for kind-ccm suck. Realistically we should just switch to metallb/kubevip and use APR advertisements directly into the mini-lab_internal network to create load balancers. I think we even did that for kamaji-lab.
kind-ccm which was kind of difficult to integrate in the first place, so metallb is worth a shot imo.
The custom Go webhook was wild either way😅
Contributor
Author
|
Cool. Thanks for taking look. I think I am fine with the proposals and would like to merge them into this PR? |
Contributor
|
Sure think, you are welcome. Cherry picked them over. Please squash merge the PR to prevent dragging in the 40MB removed webhook binary |
Signed-off-by: Benjamin Ritter <benjamin.ritter@x-cellent.com>
Signed-off-by: Benjamin Ritter <benjamin.ritter@x-cellent.com>
fixes failing gardener startup Signed-off-by: Benjamin Ritter <benjamin.ritter@x-cellent.com>
Gerrit91
force-pushed
the
remove-gardener-ingress
branch
from
August 24, 2026 09:00
96d7212 to
9a6434e
Compare
l0wl3vel
self-requested a review
August 24, 2026 09:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up of #299.
Used AI-Tools ✨