Skip to content

MBS-14224: Add myanimelist.net to the otherdbs whitelist#3696

Merged
reosarevok merged 5 commits intometabrainz:masterfrom
SuperSaltyGamer:MBS-14224
Jan 13, 2026
Merged

MBS-14224: Add myanimelist.net to the otherdbs whitelist#3696
reosarevok merged 5 commits intometabrainz:masterfrom
SuperSaltyGamer:MBS-14224

Conversation

@SuperSaltyGamer
Copy link
Copy Markdown
Contributor

Description

As also described in STYLE-1102

MyAnimeList is a manga and anime cataloging website that also has entries for voice actors, theme song performers and staff.

Artist links:
https://myanimelist.net/people/185 when talking about a person (artist).
https://myanimelist.net/character/40 when talking about a character (artist).

Label links:
https://myanimelist.net/anime/producer/1696 when talking about a company (label)

Unnormalized link examples:
https://myanimelist.net/people/185/Kana_Hanazawa
https://myanimelist.net/character/40/Luffy_Monkey_D
https://myanimelist.net/anime/producer/1696/Kadokawa

Testing

Added MyAnimeList entries to URLCleanup.js tests, otherwise tested manually on artist and label page.

Comment thread root/static/scripts/tests/Control/URLCleanup.js Outdated
Copy link
Copy Markdown
Member

@reosarevok reosarevok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, quickly tested locally that the links are cleaned up and the favicons show.

@reosarevok
Copy link
Copy Markdown
Member

And now fixed the minor eslint issues that had triggered the tests :) Let's see if they pass now.

Comment thread root/static/scripts/edit/URLCleanup.js Outdated
@reosarevok reosarevok merged commit cb58946 into metabrainz:master Jan 13, 2026
12 of 14 checks passed
@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 13, 2026

Congratulations on your first merged pull request for MusicBrainz Server! 🎉
We’re very thankful for your work, and happy to count you as part of our community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants