MBS-14152: Added Livenation Thailand URL Recognition#3665
Open
owlpharoah wants to merge 1 commit intometabrainz:masterfrom
Open
MBS-14152: Added Livenation Thailand URL Recognition#3665owlpharoah wants to merge 1 commit intometabrainz:masterfrom
owlpharoah wants to merge 1 commit intometabrainz:masterfrom
Conversation
1c9d7c9 to
a55c8b7
Compare
fixed minor errors fixed error
Member
|
Hmm. I see what you are going for here by normalizing it to the non-tero version, but that seems to be a less preferred URL (given the redirect) so it could stop working at some point. Wouldn't it be safer to just keep the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Live Nation URLs from the Thai domain (livenationtero.co.th) weren’t being cleaned or validated properly. The cleanup logic didn’t recognize this domain
Solution
Added support for livenationtero.co.th by normalizing it to livenation.co.th in cleanup which automatically redirects to the expected page.
Testing
Tested it locally by adding external event links and works as expected!