MBS-12750: Convert attach_artist_releases to React #3664
Draft
reosarevok wants to merge 3 commits intometabrainz:masterfrom
Draft
MBS-12750: Convert attach_artist_releases to React #3664reosarevok wants to merge 3 commits intometabrainz:masterfrom
reosarevok wants to merge 3 commits intometabrainz:masterfrom
Conversation
Follows the same kind of structure as the other CDToc components. Ideally we should look into whether we can redesign these a bit to share the table and row components (with optional columns as needed). This seems to be the last use of cdtoc/list.tt so I'm dropping it.
This is mostly a straight conversion, but I'm using the chance to at least reuse CDTocReleaseListRow, and make the list a bit more consistent with others, such as reusing the bottom header and string from AttachCDTocToRelease and also listing the release artist here (which is useful since it's good to know when the AC includes *other artists* in addition to the selected one). The "Show tracklist" link no longer show for releases to which the discID cannot be attached; this matches what we do elsewhere, and in any case we were not loading the tracklists for those releases so the toggle was useless.
AFAICT the last use of this we had was cdtoc/attach_list.tt which is now gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement MBS-12750
Description
This is mostly a straight conversion, but I'm using the chance to at least reuse
CDTocReleaseListRow, and make the list a bit more consistent with others, such as reusing the bottom header and string fromAttachCDTocToReleaseand also listing the release artist here (which is useful since it's good to know when the AC includes other artists in addition to the selected one).The "Show tracklist" link no longer show for releases to which the discID cannot be attached; this matches what we do elsewhere, and in any case we were not loading the tracklists for those releases so the toggle was useless.
On top of #3660
Testing
Manually, with
/cdtoc/attach?toc=1+1+15104+150&filter-artist.query=nine+inch&artist=347&tport=8000(and/cdtoc/attach?toc=1+1+15104+150&filter-artist.query=a&artist=1872008to make sure it also shows fine when the release list is empty).