MBS-12744: Convert Edit artist credit page to React#3656
Merged
reosarevok merged 5 commits intometabrainz:masterfrom Feb 3, 2026
Merged
MBS-12744: Convert Edit artist credit page to React#3656reosarevok merged 5 commits intometabrainz:masterfrom
reosarevok merged 5 commits intometabrainz:masterfrom
Conversation
This seems entirely unused.
We have cases where we just edit an artist credit directly and no containing entity is involved. This allows passing an artistCredit directly to createInitialState and in that case prefers that over the one in the (now optional) passed entity. I enforced entity existing as an invariant in the places where we actually needed. For the button id we don't need entity and in fact it would seem that state.id (which is supposed to be unique) is preferable.
This is just a straightforward conversion. In the future I will try to make some bits of the form parameterized so it can be shared with Edit artist credit.
This is basically just SplitArtistForm with a different text, so this renames that to EditArtistCreditForm and puts the doc text for each form in a separate div outside the form. I cannot see a significant reason why the docs need to be inside the form to begin with, and having them outside makes it easier to reuse (passing them as children to the hydrated form from the components is not doable, and I prefer having the form component be the full form if possible).
mwiencek
approved these changes
Feb 2, 2026
Member
mwiencek
left a comment
mwiencek
left a comment
There was a problem hiding this comment.
Tested both forms locally and didn't have any trouble entering/accepting the edits in either case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement MBS-12744
Description
On top of #2836
Straightforward conversion, but it reuses the form added for
SplitArtist. Since only the documentation shown as part of the form is really any different, I moved the documentation bits for both files to a differentdivout of the form so that only the actual form bits are reused and hydrated. It does add a bit more space between the collaborators list and the form than in prod but I actually like that, personally.Testing
Manually, both
SplitArtistand the newEditArtistCredit.