Test Python 3.15#853
Open
hugovk wants to merge 3 commits into
Open
Conversation
Contributor
|
Thanks @hugovk! Quick question: did an existing test case for symlinks fail for you on Windows py3.15? |
Author
|
Yes, you can see it here: ________________________________ test_symlinks ________________________________
tmp_path = WindowsPath('C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/test_symlinks0')
sdist_symlinks = WindowsPath('C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/test0/mesonpy-test-hklax70z/symlinks-1.0.0.tar.gz')
@pytest.mark.skipif(sys.version_info >= (3, 14) and MESON_VERSION < (1, 9, 2), reason='incompatible Python version')
@pytest.mark.filterwarnings('ignore:symbolic link')
def test_symlinks(tmp_path, sdist_symlinks):
with tarfile.open(sdist_symlinks, 'r:gz') as sdist:
names = {member.name for member in sdist.getmembers()}
mtimes = {member.mtime for member in sdist.getmembers()}
# Check that the symlinks `baz.py` and `qux.py` pointing outside the
# source tree are not included. These files are present in the
# meson-python git repository but cannot be included in the meson-python
# sdist. Thus this test is effective only when run from a git checkout.
> assert names == {
'symlinks-1.0.0/PKG-INFO',
'symlinks-1.0.0/meson.build',
'symlinks-1.0.0/pyproject.toml',
'symlinks-1.0.0/__init__.py',
'symlinks-1.0.0/submodule/__init__.py',
'symlinks-1.0.0/submodule/aaa.py',
'symlinks-1.0.0/submodule/bbb.py',
}
E AssertionError: assert {'symlinks-1.0.0/meson.build', 'symlinks-1.0.0/PKG-INFO', 'symlinks-1.0.0/submodule/bbb.py', 'symlinks-1.0.0/__init__.py', 'symlinks-1.0.0/submodule/aaa.py', 'symlinks-1.0.0/pyproject.toml'} == {'symlinks-1.0.0/submodule/aaa.py', 'symlinks-1.0.0/pyproject.toml', 'symlinks-1.0.0/meson.build', 'symlinks-1.0.0/PKG-INFO', 'symlinks-1.0.0/submodule/bbb.py', 'symlinks-1.0.0/submodule/__init__.py', 'symlinks-1.0.0/__init__.py'}
E
E Extra items in the right set:
E 'symlinks-1.0.0/submodule/__init__.py'
E
E Full diff:
E {
E 'symlinks-1.0.0/PKG-INFO',
E 'symlinks-1.0.0/__init__.py',
E 'symlinks-1.0.0/meson.build',
E 'symlinks-1.0.0/pyproject.toml',
E - 'symlinks-1.0.0/submodule/__init__.py',
E 'symlinks-1.0.0/submodule/aaa.py',
E 'symlinks-1.0.0/submodule/bbb.py',
E }
mtimes = {1781692825.0}
names = {'symlinks-1.0.0/PKG-INFO',
'symlinks-1.0.0/__init__.py',
'symlinks-1.0.0/meson.build',
'symlinks-1.0.0/pyproject.toml',
'symlinks-1.0.0/submodule/aaa.py',
'symlinks-1.0.0/submodule/bbb.py'}
sdist = <tarfile.TarFile object at 0x000002857D733410>
sdist_symlinks = WindowsPath('C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/test0/mesonpy-test-hklax70z/symlinks-1.0.0.tar.gz')
tmp_path = WindowsPath('C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/test_symlinks0')
tests\test_sdist.py:235: AssertionError
---------------------------- Captured stdout setup ----------------------------
Initialized empty Git repository in D:/a/meson-python/meson-python/tests/packages/symlinks/.git/
+ meson setup D:\a\meson-python\meson-python\tests\packages\symlinks D:\a\meson-python\meson-python\tests\packages\symlinks\.mesonpy-3wrsh3w8 -Dbuildtype=release -Db_ndebug=if-release -Db_vscrt=md --fatal-meson-warnings --native-file=D:\a\meson-python\meson-python\tests\packages\symlinks\.mesonpy-3wrsh3w8\meson-python-native-file.ini
The Meson build system
Version: 1.11.1
Source dir: D:\a\meson-python\meson-python\tests\packages\symlinks
Build dir: D:\a\meson-python\meson-python\tests\packages\symlinks\.mesonpy-3wrsh3w8
Build type: native build
Project name: symlinks
Project version: undefined
Host machine cpu family: x86_64
Host machine cpu: x86_64
Program python found: YES (C:\hostedtoolcache\windows\Python\3.15.0-beta.2\x64\python.exe)
Build targets in project: 0
symlinks undefined
User defined options
Native files: D:\a\meson-python\meson-python\tests\packages\symlinks\.mesonpy-3wrsh3w8\meson-python-native-file.ini
b_ndebug : if-release
b_vscrt : md
buildtype : release
Found ninja.EXE-1.13.0.git.kitware.jobserver-pipe-1 at C:\hostedtoolcache\windows\Python\3.15.0-beta.2\x64\Scripts\ninja.EXE
+ meson dist --allow-dirty --no-tests --formats gztar
Created D:\a\meson-python\meson-python\tests\packages\symlinks\.mesonpy-3wrsh3w8\meson-dist\symlinks-undefined.tar.gzhttps://github.com/hugovk/meson-python/actions/runs/27682956779/job/81874680435 (I had to "hack" my feature branch name as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.15 is now in beta, so it's time to start testing:
https://discuss.python.org/t/python-3-15-0-beta-2-is-here/107610
This is especially important for foundational projects such as meson-python, so libraries know they can use it for their own 3.15 testing.
Also bump GitHub Actions.