docs: fix build steps and package paths in READMEs - #1405
Conversation
Root README and apps/web README pointed to the pre-monorepo `packages/web` path and used a filter (`@meshtastic/web`) that resolves to the workspace root package, not the web app. Users following the docs hit `pnpm -r build` failures because Buf CLI is required for `@meshtastic/protobufs` to build, but was documented as optional. - Root README: clarify that libraries live under `packages/` while the reference web client lives under `apps/`; mark Buf CLI as required for `pnpm -r build`; document the topological order and add a web-only build path via `pnpm --filter meshtastic-web... build`. - apps/web README: replace `cd packages/web && pnpm install` with a root-level install; use `pnpm --filter meshtastic-web` for dev/build/ package scripts; correct the CONTRIBUTING link. Fixes meshtastic#1252
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe README files now describe the ChangesWorkspace documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This documentation-only change corrects build commands, package paths, and prerequisites; no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
`pnpm -r --sort` (default) orders packages only by their `workspace:` dependencies. `packages/ui` has no workspace dep on `@meshtastic/protobufs`, and `@meshtastic/sdk` pulls protobufs over `jsr:`, so neither is sequenced after protobufs by workspace sort. The prior wording implied a stronger guarantee than pnpm provides.
Summary
apps/web/README.mdstill pointed at the pre-monorepopackages/webpath and used the filter@meshtastic/web, which resolves to the workspace root package rather than the web app. Following the docs did not build the app.pnpm -r buildinvokesbuf generatein@meshtastic/protobufsunconditionally, so a fresh clone +pnpm -r buildfails withsh: buf: command not foundunless Buf is installed.apps/web/README.mdlinked its Contributing guide viapackages/web/CONTRIBUTING.md(broken).Fixes #1252.
Changes
README.md: clarify that libraries live underpackages/and the reference web client underapps/; mark Buf CLI required forpnpm -r build; document topological build order; add web-only build pathpnpm --filter meshtastic-web... build; fix filter name (@meshtastic/web→meshtastic-web).apps/web/README.md: replacecd packages/web && pnpm installwith a root-levelpnpm install; usepnpm --filter meshtastic-webfordev,build, andrun package; fix Contributing link (packages/web→apps/web).Test plan
pnpm installat repo root succeedspnpm -r buildsucceedspnpm --filter meshtastic-web devstarts the web clientpnpm --filter meshtastic-web... buildbuilds the web client + its workspace deps without touching every publishable packageSummary by CodeRabbit
meshtastic-web.