Fix: Update repeated field checks to use is_repeated property#908
Open
pdxlocations wants to merge 3 commits intomeshtastic:masterfrom
Open
Fix: Update repeated field checks to use is_repeated property#908pdxlocations wants to merge 3 commits intomeshtastic:masterfrom
pdxlocations wants to merge 3 commits intomeshtastic:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #908 +/- ##
==========================================
+ Coverage 59.82% 59.84% +0.01%
==========================================
Files 24 24
Lines 4329 4333 +4
==========================================
+ Hits 2590 2593 +3
- Misses 1739 1740 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Tested with older protobuf dependencies and we'd need bump to >=6.31.0 or add a fallback. |
Member
Author
|
Helper function added to test for is_repeated and fallback to label if not present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update protobuf field-inspection logic to use is_repeated instead of label where needed.
I have not tested for backwards compatibility.