Revert "Add include directive for mbedtls error handling in build flags"#10073
Revert "Add include directive for mbedtls error handling in build flags"#10073thebentern merged 1 commit intomeshtastic:developfrom
Conversation
|
From build checks I now see the compile error which the original commit was intended to fix: Will work on a fix. |
I think the include |
|
Yes you're right. That's the fix I'm working on. |
|
esp32_https_server version has been bumped, but only in master. Waiting for that to be merged into develop, then I'll be able to re-open this PR. |
@cpatulea I have backmerged master into develop this morning |
This reverts commit 391928e. Since esp32_https_server commit e2c9f98, this is no longer necessary. Also, the esp32-common.ini '-include mbedtls/error.h' causes a build error under IDF v5 (meshtastic#9122 (comment)): <command-line>: fatal error: mbedtls/error.h: No such file or directory so this change fixes that error.
|
@thebentern perfect, thank you. This PR is now ready for review. |
Pull RequestA fix has been submitted: PR #10127 Please review and merge if the changes look good. Thanks! |
There was a problem hiding this comment.
Pull request overview
Reverts a previously added global compiler -include mbedtls/error.h build flag for ESP32 targets to fix PlatformIO Arduino (pioarduino) builds that fail because that header is not available in that framework configuration.
Changes:
- Removes the
-include mbedtls/error.hdirective from ESP32 commonbuild_flags.
This reverts commit 391928e.
Fixes compile error under pioarduino:
: fatal error: mbedtls/error.h: No such file or directory
🤝 Attestations