fix: map SoftDevice variants for the new nrf52840 boards - #131
Conversation
The #6822 hardware-catalog refresh in Meshtastic-Android added nrf52840 boards that had no SoftDevice mapping here, so the OTA gate would refuse to flash them. Android PR #6843 fixed the app's bundled seed (device_bootloader_ota_quirks.json), but that seed is refreshed on a schedule from this repo's data: without the same rows here, the next scheduled refresh reverts the app fix. Derived from meshtastic/firmware ldscripts: heltec_mesh_tower_v2 links nrf52840_s140_v6.ld (SoftDevice 6.1.1); seeed_wio_tracker_L1_Pro_1W links nrf52840_s140_v7.ld (7.3.0); rak_wismesh_pocket, rak_wismesh_repeater_mini, and rak_wismesh_repeater_mini_hp all build on wiscore_rak4631 with v6 (6.1.1). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe bootloader OTA configuration adds three RAK WiMesh PlatformIO targets. It also adds soft-device variant entries for Heltec Mesh Tower V2 and Seeed Wio Tracker L1 Pro 1W. ChangesBootloader OTA configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized data update adds and corrects SoftDevice mappings for supported boards without identified merge-blocking risk; it is merge-ready after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
The Meshtastic-Android #6822 hardware-catalog refresh added nrf52840 boards with no SoftDevice mapping, so the destructive-flash gate would refuse OTA updates for them. Android PR meshtastic/Meshtastic-Android#6843 fixed the app's bundled seed (androidApp/src/main/assets/device_bootloader_ota_quirks.json), but that seed is refreshed on a schedule from this repo's resource/bootloaderOtaQuirks data. Without the same rows here, the next scheduled refresh reverts the app fix.
What
Four changes to data/bootloaderOtaQuirks.json, all under softDeviceVariants:
Derivation
From meshtastic/firmware ldscripts: heltec_mesh_tower_v2 links nrf52840_s140_v6.ld (SoftDevice 6.1.1); seeed_wio_tracker_L1_Pro_1W links nrf52840_s140_v7.ld (7.3.0); rak_wismesh_pocket, rak_wismesh_repeater_mini, and rak_wismesh_repeater_mini_hp all build on wiscore_rak4631 with v6 (6.1.1).
Testing Performed
🤖 Generated with Claude Code
https://claude.ai/code/session_012mU7P5KvLFZFNoHL4ExrBN
Summary by CodeRabbit