Register the Heltec RC32, RC52, and RCC6 in the device registry - #130
Draft
rcarteraz wants to merge 1 commit into
Draft
Register the Heltec RC32, RC52, and RCC6 in the device registry#130rcarteraz wants to merge 1 commit into
rcarteraz wants to merge 1 commit into
Conversation
Adds deviceHardware entries for the three Heltec boards whose hardware models are already reserved in the protobufs HardwareModel enum but which have no registry entry yet, so 141-143 were a gap between MESHNOLOGY_W10 and SEEED_WIO_TRACKER_L1_PRO_1W. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
deviceHardwareentries for three Heltec boards that have firmwarevariants in flight but no registry entry, so
/resource/deviceHardwarecurrently has a gap at 141-143 between
MESHNOLOGY_W10(140) andSEEED_WIO_TRACKER_L1_PRO_1W(144).HELTEC_RC32heltec-rc32HELTEC_RC52heltec-rc52HELTEC_RCC6heltec-rcc6Where the values come from
Every field was taken from the
custom_meshtastic_*block in each variant'splatformio.ini— the same databin/platformio-custom.pyemits as the buildmanifest — rather than hand-written:
HardwareModelenum values inmeshtastic/protobufsmaster (HELTEC_RC32 = 141,HELTEC_RC52 = 142,HELTEC_RCC6 = 143) and are already present in the firmware's checked-inmesh.pb.h, so no submodule bump is involved.platformio-custom.pyproduces(
esp32-s3,nrf52840,esp32-c6).16MBfor RC32 and RCC6 agrees with theirboard_build.partitions = default_16MB.csv, their board JSONbuild.arduino.partitions, andupload.flash_size/maximum_size(16777216). RC52 is nRF52840 and correctly has none — no nrf52840 variant
in the firmware repo sets a partition scheme.
truefor RC52 (forced for all nrf52840 targets) and forRC32 (declared in its variant, consistent with the other esp32-s3 entries),
and
falsefor RCC6, matching both existing esp32-c6 variants.HAS_TFT,which is the only thing
platformio-custom.pyderiveshas_muifrom. Theydo set
USE_TFTDISPLAY, but that is the plain TFT screen path, not MUI.activelySupportedisfalsefor all three, matching the neighbouringentries — happy to flip any of them if these are meant to ship as supported.
Follow-ups outside this PR
heltec_rc32.svg,heltec-rc52.svg,heltec_rcc6.svg— are not inmeshtastic/web-flasherpublic/img/devices/. They need to land there, andthe names must match these strings byte-for-byte. Note the firmware variants
themselves are inconsistent about hyphen vs. underscore here; I mirrored
what each variant declares rather than normalizing, so if web-flasher
prefers one style these entries should change with it.
board_level = extra, whichbin/generate_ci_matrix.pyonly includes on an explicit--level extra.Until that becomes
release, RC32 will not build in the release matrix, sothis registry entry will point at a target that produces no firmware.
developand need a rebase.Checks run locally:
tsc --noEmit --strictonsrc/lib/resource.tspasses,biome ci src/lib/resource.tsis clean, and the diff is purely additive(38 insertions, 0 deletions) with no duplicate
platformioTarget.🤖 Generated with Claude Code