refactor(car)!: remove the Android Auto integration from all build variants - #6779
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (36)
💤 Files with no reviewable changes (34)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Android Auto car feature is removed from the Gradle project, Google app wiring, CI test and coverage shards, feature implementation, resources, documentation, and tests. ChangesCar feature removal
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change removes the Android Auto integration and its build wiring while retaining the documented in-app page; the reported full build and test checks pass, so no actionable merge-blocking risk remains beyond normal review. 🚥 Pre-merge checks | ✅ 7 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (7 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
c905c7f to
4c04d97
Compare
…riants Google Play has rejected three consecutive submissions (Jul 25, Aug 12, Aug 19) under Auto App Quality Guidelines review — a lens the app enters solely by declaring com.google.android.gms.car.application. Production only ever shipped notification-only car messaging; the templated CarAppService was already gated to flag builds that never reach a reviewed track. Removing the entire integration (module, manifests, build wiring, DI include, catalog entries) exits car-app review so the 2.8.1 release — which carries the reviewer-facing Demo Mode — can clear. Deliberately kept: the in-app Android Auto docs page and its translations, so this commit stays cleanly revertable when the templated messaging program is ready to resubmit. Revert this commit to restore the integration wholesale. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
4c04d97 to
860c0f0
Compare
The labeler's conventional-commit title regex required the type/scope to be followed immediately by ":", so titles carrying the breaking-change marker "!" (e.g. "refactor(car)!: ...") failed to match and the PR got no type/scope labels (observed on #6779). Allow an optional "!" before the colon. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Why
Google Play has rejected three consecutive submissions — Jul 25 ("Category not permitted"), Aug 12, and Aug 19 (both "Login Credentials") — every one filed under Auto App Quality Guidelines review. The app enters that review lens through a single manifest declaration:
com.google.android.gms.car.application. Production only ever shipped notification-only car messaging behind it; the templatedCarAppServiceexperience was already gated to-PenableCarTemplates=truebuilds that never reach a reviewed track. The lens has now cost five weeks of blocked releases and a missed DEF CON window, against a modest feature. This removes the entire integration so the 2.8.1 release — which carries the reviewer-facing Demo Mode (#6691) — can clear review.Revert this PR's commit to restore the integration wholesale when the templated-messaging program is ready to resubmit deliberately.
🧹 Removed
feature/car/— entire module:MeshtasticCarAppService, car screens, DI module, tests, both manifests (production<meta-data>and the flag-gated templatedCarAppService), drawables,automotive_app_desc.xmlandroidApp—enableCarTemplatesproperty wiring,googleCarTemplatesres override,googleImplementation(projects.feature.car)FlavorModule—FeatureCarModuleimport + includesettings.gradle.ktsmodule include; all fourcar-appversion-catalog entries (stops Renovate bumping a dead dependency)Deliberately kept
The in-app Android Auto docs page and its translations — removing them would touch the docs registry and every Crowdin locale file, making the future revert messier for purely cosmetic gain while the page describes a temporarily absent feature.
Testing Performed
Full baseline on the rebased branch (
origin/main+ this commit):spotlessApply spotlessCheck detekt assembleDebug test allTests— BUILD SUCCESSFUL, zero<failure>/<error>tags across 711 fresh test-result XML files. Repo-wide grep confirms zero residual references (feature.car,FeatureCarModule,enableCarTemplates,androidx.car,automotive_app_desc) outside deleted paths. Note: an earlier run failed onSoftDeviceQuirkCoverageTest(hwModel 136) — pre-existing at the branch point, fixed by #6776, gone after rebase.🤖 Generated with Claude Code
Summary by CodeRabbit