Skip to content

fix: avoid redundant redefinition of SX126X_DIO3_TCXO_VOLTAGE #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ssp97 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: avoid redundant redefinition of SX126X_DIO3_TCXO_VOLTAGE #1483

ssp97 wants to merge 1 commit into from
+3 −6

Conversation

@ssp97
Copy link

@ssp97 ssp97 commented Jan 26, 2026

SX126X_DIO3_TCXO_VOLTAGE was repeatedly defined in header files when
multiple headers were included, leading to unintended TCXO voltage
override.

Ensure the macro is defined only once.

#include <helpers/radiolib/CustomSX1262Wrapper.h>   <- ok
#include <helpers/radiolib/CustomSX1268Wrapper.h>   <- ng

@ssp97 ssp97 mentioned this pull request Jan 26, 2026
Closed
oltaco
oltaco approved these changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@oltaco oltaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@oltaco oltaco oltaco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ssp97 @oltaco