Conversation
…e boundary (#528) When a nested ExclusiveSplit inside traverseFlowUntilMerge matched the guard pattern (true branch terminates, false branch looks like continuation), the guard continuation code would "skip through" any ExclusiveMerge on the false path. If that merge happened to be the outer mergeID, activities after the merge were traversed and marked visited inside the then-block — leaving nothing for continueAfterSplitJoin to emit after `end if;`. Fix: add `if contID != mergeID` before the skip-through so the guard continuation never crosses the outer merge boundary. Activities that follow the outer merge are now correctly emitted outside the if block. Regression test: TestTraverseFlow_Issue528_NestedGuardDoesNotSwallowSharedActivities Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…079) When exactly one non-split branch continues and the rest terminate, the builder was wiring the parent's next statement directly to the continuing branch tail and skipping the ExclusiveMerge. Studio Pro raised CE0079 on terminating branches because they had no merge to converge on. Fix: always emit ExclusiveMerge when any branch continues, mirroring the invariant addEnumSplit already enforces. Also adds: - TestInheritanceSplitAlwaysEmitsMergeWhenBranchContinues - TestValidateMicroflowReferences_DescendsIntoEnumSplitCases regression test - mdl-examples/bug-tests/475-inheritance-split-continuing-branch-merge.mdl - cast roundtrip warning in write-microflows.md Closes #475 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
AI Code ReviewCritical IssuesNone found. Moderate IssuesNone found. Minor Issues
What Looks Good
RecommendationApprove. The PR fixes two specific microflow bugs with appropriate test coverage, documentation updates, and clean code changes. The fixes are well-justified, minimally invasive, and follow existing patterns in the codebase. No checklist violations were found for this type of bug fix PR. Automated review via OpenRouter (Nemotron Super 120B) — workflow source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.