changed regex for VN#269
Merged
melwynfurtado merged 1 commit intomelwynfurtado:masterfrom Mar 20, 2026
Merged
Conversation
melwynfurtado
approved these changes
Mar 20, 2026
Owner
|
Thanks for the update 🙂 |
Contributor
Author
|
@melwynfurtado thank you! Can you please create a new version with this fix? |
Owner
|
🎉 This PR is included in version 3.10.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Owner
Included now, didn't realise the commit message was not as per semantic release's conventional commit format. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Update Vietnam (VN) postcode validation to support the official 5-digit format.
Currently, the validator strictly enforces a 6-digit format for Vietnam. However, according to the Ministry of Information and Communications (MIC) of Vietnam (Decision 2495/QD-BTTTT) and the Universal Postal Union (UPU), Vietnam officially transitioned to a 5-digit postal code system on January 1, 2018.
This PR updates the regex for
CountryCode.VN to /^\d{5,6}$/.Why 5 to 6 digits? While 5 digits is the current official standard, many legacy systems, international couriers, and users still utilize the older 6-digit format (often by appending a '0'). Supporting both ensures backward compatibility while aligning with the modern national standard.
Who should review this PR?
@melwynfurtado (or any maintainers responsible for regional validation updates).
Sources: