perf: pre-allocate HashMap and remove redundant intermediate Vec in multiproof.rs#125
Open
KENILSHAHH wants to merge 1 commit intomegaeth-labs:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FxHashMapingroup_prover_querieswithwith_capacity_and_hasher(prover_queries.len(), ...)to avoid repeated rehashing as entries are addedcollectintoVec+ manualpar_chunks(len / num_threads)splitting inMultiPoint::open, replacing with directinto_par_iter().map()whicheliminates one Vec allocation and lets rayon's work-stealing handle load balancing
Context
Both changes are in
ipa-multipoint/src/multiproof.rs, in theMultiPoint::openproof generation hot path.The HashMap was starting at default capacity and resizing multiple times as queries were inserted. Since we know the number of queries upfront, we pre-allocate.
The old parallelization pattern collected a HashMap into a Vec just to call
par_chunks()with a manually computed chunk size. This added an unnecessary allocation andrigid equal-sized splitting. Rayon's
into_par_iter()on HashMap already provides parallel iteration with work-stealing, which handles uneven workloads better than fixedchunking.