Skip to content

test: add Rex4 system contract deployment and idempotence tests -v2#203

Merged
Troublor merged 3 commits intomegaeth-labs:mainfrom
viktorcrypt:viktorcrypt/test/rex4-system-contract-deployment-v2
Apr 1, 2026
Merged

test: add Rex4 system contract deployment and idempotence tests -v2#203
Troublor merged 3 commits intomegaeth-labs:mainfrom
viktorcrypt:viktorcrypt/test/rex4-system-contract-deployment-v2

Conversation

@viktorcrypt
Copy link
Copy Markdown
Contributor

Summary

Adds Rex4 deployment tests for MegaAccessControl and MegaLimitControl, covering:

  • activation on Rex4
  • idempotent repeated apply_pre_execution_changes()
  • Rex3 boundary behavior (not deployed before Rex4)

Also incorporates the requested review follow-up:

  • use production-like hardfork activation with with_all_activated()
  • check KECCAK_EMPTY for the non-deployed case
  • extract repeated executor setup into a shared helper

Note

This PR replaces #187, which got stuck due to a GitHub fork-lineage issue after the repository outage. All review feedback from Troublor has been incorporated here. Please consider closing #187 in favor of this one.

@viktorcrypt viktorcrypt force-pushed the viktorcrypt/test/rex4-system-contract-deployment-v2 branch from 2fcaa26 to ee21de5 Compare March 20, 2026 09:16
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.5%. Comparing base (2bba707) to head (ee21de5).
⚠️ Report is 13 commits behind head on main.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@Troublor Troublor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Troublor Troublor added comp:core Changes to the `mega-evm` core crate spec:unchanged No change to any `mega-evm`'s behavior api:unchanged No change to the public interface or API labels Apr 1, 2026
@Troublor Troublor merged commit 6192b1d into megaeth-labs:main Apr 1, 2026
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api:unchanged No change to the public interface or API comp:core Changes to the `mega-evm` core crate spec:unchanged No change to any `mega-evm`'s behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants