Engine(-Twitter),Frontend: avoid Close warning dialog (closes: #1093)#256
Open
knocte wants to merge 2 commits intomeebey:masterfrom
Open
Engine(-Twitter),Frontend: avoid Close warning dialog (closes: #1093)#256knocte wants to merge 2 commits intomeebey:masterfrom
knocte wants to merge 2 commits intomeebey:masterfrom
Conversation
knocte
force-pushed
the
twitterWarnCloseDialog
branch
2 times, most recently
from
070f385 to
fb910ec
Compare
Contributor
Author
|
@meebey ping? :) |
Methods that start with "On" are normally the ones that get called because they got subscribed to some event. In this case, this method is the one in charge of raising that event so to make it a bit less confusing, let's rename it to have the "Raise" prefix instead of "On".
There are some protocols, like Twitter, in which there are no consequences from disconnecting from the server: no unavailable status is shown to our contacts, and no chat buffers will be lost because all the info resides server-side. For these, there is not really any point in warning the user about current open chats when she intends to close the connection, so let's whitelist Twitter in this way to avoid the pointless dialog.
knocte
force-pushed
the
twitterWarnCloseDialog
branch
from
fb910ec to
41b248b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some protocols, like Twitter, in which there are no
consequences from disconnecting from the server: no unavailable
status is shown to our contacts, and no chat buffers will be
lost because all the info resides server-side. For these, there
is not really any point in warning the user about current open
chats when she intends to close the connection, so let's
whitelist Twitter in this way to avoid the pointless dialog.