feat(logs): give up on missing connections#1483
Merged
Merged
Conversation
Collaborator
Author
|
Scenario 1 (Nothing is listening): Scenario 2 (Service disappeared for a bit): |
f5a0b88 to
4dcee6f
Compare
Implement an isolated, unit-based reconnection tracking engine inside the background logging handler thread. This structure natively handles both instant startup dropouts (never listening) and long-term service disappearances without tracking raw wall-clock timers. Key architectural controls: - Encapsulates dynamic telemetry properties (budget, first-failure snapshot, timeout values, and bonus/cost configurations) directly inside a private _ReconnectionState dataclass instantiated inside the thread. - Implements a 2:1 recovery ratio (failures cost 5 units; successful handshakes reward 10 units plus 1 unit per item sent) capped strictly at 1,000 units. - Implements a narrow-band jitter range combined with a 1.0+ additive guard. This prevents rapid-fire sub-second retry loops on early drops while injecting fractional millisecond variance to break up concurrent thundering herds.
fd86547 to
0c6503d
Compare
meeb
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement an isolated, unit-based reconnection tracking engine inside the background logging handler thread. This structure natively handles both instant startup dropouts (never listening) and long-term service disappearances without tracking raw wall-clock timers.
Key architectural controls: