fix: prevent blank screen when changing category in Unit Converter #31#34
Merged
me-shaon merged 3 commits intome-shaon:mainfrom Apr 7, 2026
Merged
Conversation
- Safely reset fromUnit/toUnit when category changes - Added safety checks and try/catch - Fixes me-shaon#31
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the robustness of the UnitConverter component by implementing safety checks for unit selection, wrapping conversion logic in a try-catch block, and utilizing optional chaining for unit display. Key feedback includes refactoring the result formatting logic to use an existing utility function to maintain DRY principles and adjusting the conditional rendering of unit names to prevent visual spacing issues when units are undefined.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Import formatResult from utils/unit-converter and replace the manual integer/decimal formatting with a single call to formatResult when setting the converted value. Also refactor the inline JSX output into separate concatenated expressions for clearer rendering. These changes centralize result formatting and clean up the component's display logic.
Contributor
Author
|
Assalamualaikum @me-shaon vai, |
Owner
|
@Krak3n909 Thanks for the contribution. |
Contributor
Author
|
Thanks for taking the time to review this PR, I appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug in the Unit Converter where changing the category would cause the entire app to show a blank screen.
Changes
fromUnitandtoUnitwhen the category changesThis resolves the crash reported in #31.
Testing
Closes #31