Conversation
Contributor
|
Preview URLs (1 page) (comment last updated: 2026-02-26 09:53:33) |
dipikabh
requested changes
Feb 26, 2026
Contributor
dipikabh
left a comment
There was a problem hiding this comment.
Changes look good. Thanks for sending the PR!
One small thing to update: for key combos, could you add a separate <kbd> for each key? So <kbd>Shift</kbd>+<kbd>W</kbd>
k-yle
commented
Feb 26, 2026
k-yle
commented
Feb 26, 2026
Contributor
Author
|
sure, done |
jdatapple
pushed a commit
to jdatapple/content
that referenced
this pull request
Mar 6, 2026
* use <kbd> to format keyboard keys * code review suggestions * code review suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced "W" with W (using
<kbd>)Motivation
This page is inconsistent with the sibling pages that correctly use
<kbd>.The inconsistent use of quotation marks is also a bit weird.
Additional details
Related issues and pull requests