Skip to content

use <kbd> to format keyboard keys#43173

Merged
dipikabh merged 3 commits intomdn:mainfrom
k-yle:patch-2
Feb 26, 2026
Merged

use <kbd> to format keyboard keys#43173
dipikabh merged 3 commits intomdn:mainfrom
k-yle:patch-2

Conversation

@k-yle
Copy link
Copy Markdown
Contributor

@k-yle k-yle commented Feb 20, 2026

Description

Replaced "W" with W (using <kbd>)

Motivation

This page is inconsistent with the sibling pages that correctly use <kbd>.
The inconsistent use of quotation marks is also a bit weird.

Additional details

Related issues and pull requests

@k-yle k-yle requested a review from a team as a code owner February 20, 2026 08:56
@k-yle k-yle requested review from dipikabh and removed request for a team February 20, 2026 08:56
@github-actions github-actions Bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Feb 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 20, 2026

Preview URLs (1 page)

(comment last updated: 2026-02-26 09:53:33)

Copy link
Copy Markdown
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks for sending the PR!

One small thing to update: for key combos, could you add a separate <kbd> for each key? So <kbd>Shift</kbd>+<kbd>W</kbd>

Comment thread files/en-us/web/api/keyboard/lock/index.md Outdated
Comment thread files/en-us/web/api/keyboard/lock/index.md Outdated
@k-yle
Copy link
Copy Markdown
Contributor Author

k-yle commented Feb 26, 2026

sure, done

@k-yle k-yle requested a review from dipikabh February 26, 2026 09:52
Copy link
Copy Markdown
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@dipikabh dipikabh merged commit a3fd44c into mdn:main Feb 26, 2026
8 checks passed
@k-yle k-yle deleted the patch-2 branch February 28, 2026 13:24
jdatapple pushed a commit to jdatapple/content that referenced this pull request Mar 6, 2026
* use <kbd> to format keyboard keys

* code review suggestions

* code review suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants