Skip to content

update examples for background-attachment #43103

Merged
pepelsbey merged 17 commits intomainfrom
bgattach
Mar 11, 2026
Merged

update examples for background-attachment #43103
pepelsbey merged 17 commits intomainfrom
bgattach

Conversation

@estelle
Copy link
Copy Markdown
Member

@estelle estelle commented Feb 12, 2026

added text explaining examples
updated the examples to ensure something noticeable would happen

@estelle estelle requested review from a team as code owners February 12, 2026 14:55
@estelle estelle requested review from pepelsbey and removed request for a team February 12, 2026 14:55
@github-actions github-actions Bot added Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs size/m [PR only] 51-500 LoC changed labels Feb 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 12, 2026

Preview URLs (1 page)

(comment last updated: 2026-03-10 10:02:36)

@github-actions github-actions Bot removed the Content:HTML Hypertext Markup Language docs label Feb 12, 2026
@Josh-Cena Josh-Cena removed the request for review from a team February 12, 2026 15:24
Copy link
Copy Markdown
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you for updating the examples. But I noticed that there’s more than just CSS here.

We discussed it in the content team and agreed that changing example content doesn’t add much value (it wasn’t broken), but the opposite: it changes relatively neutral text into heavy and somewhat disturbing one. This change is also missing from the PR description, although it takes up to half of the changed lines.

I would suggest reverting the old demo text and focusing on the code as the most valuable part of this example.

estelle and others added 6 commits February 26, 2026 14:00
Updated examples to use lists instead of paragraphs and modified related text.
…/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Fix formatting of interactive example in background-attachment documentation.
@estelle estelle requested a review from pepelsbey February 26, 2026 13:08
Comment thread files/en-us/web/css/reference/properties/background-attachment/index.md Outdated
@estelle
Copy link
Copy Markdown
Member Author

estelle commented Feb 26, 2026

Hey! Thank you for updating the examples. But I noticed that there’s more than just CSS here.

We discussed it in the content team and agreed that changing example content doesn’t add much value (it wasn’t broken), but the opposite: it changes relatively neutral text into heavy and somewhat disturbing one. This change is also missing from the PR description, although it takes up to half of the changed lines.

I would suggest reverting the old demo text and focusing on the code as the most valuable part of this example.

I changed it to Dr. Seuss, so the user can better see which line they are on as it scrolls

estelle and others added 3 commits March 2, 2026 15:27
…/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you 🙂

@pepelsbey pepelsbey merged commit e478400 into main Mar 11, 2026
12 checks passed
@pepelsbey pepelsbey deleted the bgattach branch March 11, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants