Make the code robust against duplicated timeouts#167
Open
PetrDlouhy wants to merge 1 commit intomdbootstrap:masterfrom
Open
Make the code robust against duplicated timeouts#167PetrDlouhy wants to merge 1 commit intomdbootstrap:masterfrom
PetrDlouhy wants to merge 1 commit intomdbootstrap:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is number of cases (i.e. two buttons triggering same dropdown) when the code would set up multiple timeouts at the same time. This can easily lead to weird and unexpected behavior such as dropdown hiding at unexpected moments when the mouse is still hovering over the active elements.
If we keep all the timeouts in array and clear all of them all of them, it would make the code robust against such problems.
I expect that even the
stop this eventif conditions might not be needed anymore.