Merge KaTeX symbol tables into single lookup map (depends on #7)#8
Closed
chitwitgit wants to merge 8 commits into
Closed
Merge KaTeX symbol tables into single lookup map (depends on #7)#8chitwitgit wants to merge 8 commits into
chitwitgit wants to merge 8 commits into
Conversation
Replace the hand-maintained symbol map with generated tables seeded from KaTeX v0.16.22 source snippets, add accent and function handling, and document regeneration via pnpm generate:katex. Fixes md2docx#6
Map n-ary operators, binom, stackrel, accents, and font wrappers to proper Word OMML instead of Unicode fallbacks; fix quad/ne/cdots codegen overrides.
Log console errors and omit unrenderable OMML instead of emitting empty <m:oMath> elements that break Microsoft Word.
Add concrete newly-supported LaTeX examples to sample.md so DOCX benefits are easy to spot. Replace vendored KaTeX snippets with codegen that fetches KaTeX v0.16.22 from GitHub (symbols.js, macros.js, functions/op.js).
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Jun 18, 2026 1:55a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
4 tasks
Contributor
|
Hi, Thanks and sorry for the delay. A bit busy. Can you please merge both of your branches and update this PR with main. There were some issues with pnpm etc. so I had to push a few updates to the infra. Thanks and regards, |
Flatten symbol, alias, and override entries into one generated katexData.ts object literal for a smaller minified bundle (~1.7% gzip savings vs three-table lookup). Add a benchmark script to compare serialization formats.
f883df0 to
a2bab65
Compare
Author
|
Folded into #7 — both branches are now merged on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #7 — merge that first, then this adds one commit on top.
Merges the generated
katexSymbols.tsandkatexMeta.tsalias/override tables into a singlekatexData.tswith one flat lookup map at runtime.KATEX_SYMBOLS[name]JSON.parseblobs)lib/scripts/benchmark-bundle-formats.tsto compare serialization formatsBundle size (local
pnpm buildinlib/)Full symbol coverage is unchanged — this is a serialization/layout optimization only.
Test plan
pnpm buildpasses inlib/pnpm testpasses inlib/