[ferry]: Winthrop, Quincy ferries are missing their stops on /stops#3277
Open
lvachon1 wants to merge 1 commit into
Open
[ferry]: Winthrop, Quincy ferries are missing their stops on /stops#3277lvachon1 wants to merge 1 commit into
lvachon1 wants to merge 1 commit into
Conversation
… API. We default to direction 0 when listing stops on the stops page. This change defaults to direction 1 instead. Should the API be updated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: ⛴️ Winthrop, Quincy ferries are missing their stops on /stops
Implementation
Routes Boat-F6 and Boat-F7 have no stops when direction_id = 0 in the API. We default to direction 0 when listing stops on the stops page. This change defaults to direction 1 instead. Should the API be updated?
API direction_id=1: https://api-v3.mbta.com/stops?filter%5Broute%5D=Boat-F6&filter[direction_id]=1
API direction_id=0: https://api-v3.mbta.com/stops?filter%5Broute%5D=Boat-F6&filter[direction_id]=0
Boat-F7 shows the same
Screenshots
How to test
http://localhost:4001/stops/ferry#ferry-tab
Confirm that the Winthrop and Quincy ferries have their stops listed on the stop page
Confirm that all other lines still show their stops now that we've revered the direction