Document 1000-char limit for report-transaction notes#1671
Open
faktas2 wants to merge 1 commit into
Open
Conversation
Deploying dev-site with
|
| Latest commit: |
ba0e63d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2209322d.dev-site-4ua.pages.dev |
| Branch Preview URL: | https://faktas-document-notes-limit.dev-site-4ua.pages.dev |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the transaction reporting documentation to specify a limit of 1000 Unicode characters for the notes field and adds the corresponding NOTES_INVALID error code. The reviewer pointed out a style guide violation where a comma should be added before the conjunction "so" in the notes field description.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| | **maxmind_id** | string (8) | _Conditionally required.[^1]_ A unique eight character string identifying a minFraud Standard or Premium request. These IDs are returned in the `maxmindID` field of a response for a successful minFraud request. | | ||
| | **minfraud_id** | string (36) | _Conditionally required.[^1]_ A UUID that identifies a minFraud Score, minFraud Insights, or minFraud Factors request. This ID is returned at `/id` in the response. | | ||
| | **notes** | string | _Optional._ Your notes on the fraud tag associated with the transaction. We manually review many reported transactions to improve our scoring for you so any additional details to help us understand context are helpful. | | ||
| | **notes** | string | _Optional._ Your notes on the fraud tag associated with the transaction. We manually review many reported transactions to improve our scoring for you so any additional details to help us understand context are helpful. Must be 1000 Unicode characters or fewer. | |
Contributor
There was a problem hiding this comment.
According to the repository style guide, a comma should be used between independent clauses joined by conjunctions (such as "so"). Please add a comma before "so".
Suggested change
| | **notes** | string | _Optional._ Your notes on the fraud tag associated with the transaction. We manually review many reported transactions to improve our scoring for you so any additional details to help us understand context are helpful. Must be 1000 Unicode characters or fewer. | | |
| | **notes** | string | _Optional._ Your notes on the fraud tag associated with the transaction. We manually review many reported transactions to improve our scoring for you, so any additional details to help us understand context are helpful. Must be 1000 Unicode characters or fewer. | |
References
- Use commas between independent clauses joined by conjunctions. (link)
Add the character limit to the notes field description and add the NOTES_INVALID error code to the response error table. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
faktas2
force-pushed
the
faktas/document-notes-limit-on-report-transaction-api
branch
from
68ed608 to
ba0e63d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notesfield description in the Request Body tableNOTES_INVALIDerror code to the Response error tableRelated to internal issue UHU-2728.