Update to new newton modelbuilder and experimental coupled solvers#1
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request primarily refactors the codebase to update all references to experimental coupled solvers in the Newton physics engine, reflecting a recent renaming and reorganization of these classes and their import paths. Additionally, it standardizes the use of the
xformparameter for shape transformations in shape-adding methods, replacing the previous use of separateposandrotparameters. These changes improve code clarity, maintainability, and compatibility with upstream updates.Key changes include:
Refactoring for Newton Coupled Solver Renaming and Import Path Updates
SolverProxyCoupled,SolverAdmmCoupled, and their related configs to the new namesSolverCoupledProxy,SolverCoupledAdmm, and updated their import paths fromnewton.solvers.coupled_experimentaltonewton.solvers.experimental.coupledthroughout the codebase. [1] [2] [3]Shape Transformation API Standardization
posandrotarguments with a singlexformargument (representing the full transformation) in all shape-adding methods incoupled_builder.pyandsimulation.py. This affects spheres, boxes, capsules, and mesh shapes, ensuring consistent and modern API usage. [1] [2] [3] [4] [5]These updates ensure the codebase remains compatible with the latest Newton solver APIs and improve the maintainability and readability of shape construction logic.