Fix unlocker_daemon.py for Ubuntu 18.04 and onwards.#5
Open
appositeit wants to merge 1 commit intomaxchehab:masterfrom
Open
Fix unlocker_daemon.py for Ubuntu 18.04 and onwards.#5appositeit wants to merge 1 commit intomaxchehab:masterfrom
appositeit wants to merge 1 commit intomaxchehab:masterfrom
Conversation
From 18.04 Ubuntu changed back to the Gnome desktop, and a bunch of the tooling used in the unlocker-daemon.py broke. To fix this we need to: * Identify the user who's session we want to unlock * Get the DBUS_SESSION_BUS_ADDRESS for their dbus.SessionBus() * seteuid to their uid The original script looks for the first 'real' user in /etc/shadow. I look for the first process run by a non-daemon user process with a DBUS_SESSION_BUS_ADDRESS in their environment and use that BUS_ADDRESS and user's uid to seteuid. The orginal script shells out to control the screensaver, I've modified it to use python dbus commands to query screenlock status and lock/unlock the screensaver. I think it should work with various window managers, but it's only been tested on gnome. Behaviour is undefined if there are several user sessions with window managers running.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From 18.04 Ubuntu changed back to the Gnome desktop, and a bunch of the
tooling used in the unlocker-daemon.py broke.
To fix this we need to:
The original script looks for the first 'real' user in /etc/shadow. I
look for the first process run by a non-daemon user process with a
DBUS_SESSION_BUS_ADDRESS in their environment and use that BUS_ADDRESS
and user's uid to seteuid.
The orginal script shells out to control the screensaver, I've modified
it to use python dbus commands to query screenlock status and
lock/unlock the screensaver. I think it should work with various window
managers, but it's only been tested on gnome. Behaviour is undefined if
there are several user sessions with window managers running.