Conversation
… dates and enhance ParticleBackground component with WebGL detection and fallback
Update contact section
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the portfolio UI/UX (fonts, styling, content), improves runtime resilience (Three.js fallback + error boundary), adds runtime prop validation, and adjusts CI triggering to focus on a development branch.
Changes:
- Switches from Google Fonts to locally bundled
@fontsourcefonts and tweaks some UI colors. - Refactors the hero background to handle WebGL unavailability (2D fallback) and adds an error boundary wrapper.
- Enhances components with
prop-typesand updates the contact form to submit via FormSubmit.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.jsx | Adds @fontsource imports to bundle fonts locally. |
| src/index.css | Updates hover/background colors for buttons and skill tags. |
| src/data/skills.js | Removes old skills data (no longer used). |
| src/components/Skills.jsx | Removes the standalone Skills section component. |
| src/components/Projects.jsx | Adds PropTypes + stabilizes skeleton keys during loading. |
| src/components/ParticleBackground.jsx | Adds WebGL detection + Canvas 2D fallback + cleanup improvements. |
| src/components/Hero.jsx | Wraps particle background with an error boundary and adjusts copy/spacing. |
| src/components/Footer.jsx | Updates social links, navigation items, and footer text/badges. |
| src/components/Experience.jsx | Adjusts an experience period date. |
| src/components/Contact.jsx | Updates contact details, adds async FormSubmit submission + honeypot + better accessibility hooks + PropTypes. |
| src/components/Certifications.jsx | Adds PropTypes for certification cards. |
| src/components/About.jsx | Updates social links (GitHub/LinkedIn/X/Email). |
| package.json | Adds @fontsource/* and prop-types dependencies (and reorders deps). |
| package-lock.json | Locks new dependencies. |
| index.html | Removes Google Fonts <link> tags (fonts now bundled). |
| eslint.config.js | Removes unused @eslint/js import. |
| .github/workflows/ci-cd.yml | Changes CI triggers to run only on dev. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+16
to
+20
| category: PropTypes.string.isRequired, | ||
| tech: PropTypes.arrayOf(PropTypes.string).isRequired, | ||
| githubLink: PropTypes.string.isRequired, | ||
| demoLink: PropTypes.string, | ||
| year: PropTypes.oneOfType([PropTypes.number, PropTypes.string]).isRequired, |
Comment on lines
3
to
+7
| on: | ||
| push: | ||
| branches: [main, fix/pipeline_ci_cd] | ||
| branches: [dev] | ||
| pull_request: | ||
| branches: [main] | ||
| branches: [dev] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.