Fix/pipeline ci cd#1
Merged
Merged
Conversation
…r-compose.yml, implement CI/CD pipeline, and update portfolio assets
…icons from About, Contact, and Hero components
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR adds CI/CD and quality tooling for the React/Vite portfolio, while adjusting static asset references and removing unused icon imports.
Changes:
- Adds GitHub Actions CI/CD jobs for linting, audit, secret scanning, SonarQube, and build artifacts.
- Adds ESLint flat config and related dev dependencies.
- Moves image/icon usage toward
public/assets and adds Docker Compose support for SonarQube/PostgreSQL.
Reviewed changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci-cd.yml |
Adds CI/CD workflow stages for lint, security checks, SAST, and build. |
.env.example |
Adds environment placeholders for PostgreSQL and SonarQube image versions. |
docker-compose.yml |
Adds local SonarQube and PostgreSQL services. |
eslint.config.js |
Adds ESLint flat config for React source files. |
index.html |
Updates favicon and Apple touch icon paths to public assets. |
package.json |
Adds lint script and ESLint-related dev dependencies. |
package-lock.json |
Locks newly added linting dependencies. |
public/logo.png |
Adds the logo used by HTML icon links. |
src/components/About.jsx |
Updates image path and removes an unused icon import. |
src/components/Contact.jsx |
Removes an unused icon import. |
src/components/Hero.jsx |
Removes an unused icon import. |
Comments suppressed due to low confidence (2)
.github/workflows/ci-cd.yml:57
- Using the mutable
mainbranch for this security action makes the workflow non-reproducible and allows upstream changes to alter the scanner code without review. Pin this action to a released version or, preferably for supply-chain hardening, a commit SHA.
uses: trufflesecurity/trufflehog@main
.github/workflows/ci-cd.yml:68
- This allows the SAST job to fail without failing the workflow, and the build job does not depend on
sonarqube, so SonarQube findings or scanner failures cannot gate the pipeline. If this stage is intended as a CI security control, removecontinue-on-errorand include it in the required job chain.
continue-on-error: true
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "build": "vite build", | ||
| "preview": "vite preview" | ||
| "preview": "vite preview", | ||
| "lint": "eslint src" |
| 'react-hooks': reactHooks, | ||
| 'react-refresh': reactRefresh, | ||
| }, | ||
| rules: { |
Comment on lines
+7
to
+8
| POSTGRES_VERSION= | ||
| SONARQUBE_VERSION= No newline at end of file |
| jobs: | ||
| # ── STAGE: TEST ───────────────────────────────────────────────────────────── | ||
| lint: | ||
| name: Lint & Format |
| <link rel="icon" type="image/png" href="/src/images/logo.png" /> | ||
| <link rel="apple-touch-icon" href="/src/images/logo.png" /> | ||
| <link rel="icon" type="image/png" href="/logo.png" /> | ||
| <link rel="apple-touch-icon" href="/logo.png" /> |
Comment on lines
+25
to
+28
| "eslint": "^8.57.0", | ||
| "eslint-plugin-react": "^7.34.1", | ||
| "eslint-plugin-react-hooks": "^4.6.2", | ||
| "eslint-plugin-react-refresh": "^0.4.6", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.