implement a strip_pre configuration option (#218)#222
Merged
chrispy-snps merged 2 commits intomatthewwithanm:developfrom Jun 14, 2025
Merged
Conversation
Signed-off-by: chrispy <chrispy@synopsys.com>
Collaborator
Author
|
@AlexVonB, what are your thoughts on the following: |
AlexVonB
approved these changes
May 28, 2025
Collaborator
AlexVonB
left a comment
There was a problem hiding this comment.
Looks good! I personally feel that the number 1 looks off, so I am in favor for ONE (as well in the code). The default could also be STRIP_ONE, like described in MDN: they ignore only the first newline. But both ist fine with me!
Collaborator
Author
|
@AlexVonB - I was thinking of default to @matthewwithanm - want to be a tie-breaking vote? :) |
Collaborator
|
Sorry for the late response: let's go with your proposal! |
Signed-off-by: chrispy <chrispy@synopsys.com>
23952e7 to
fedf535
Compare
Collaborator
Author
|
Thanks @AlexVonB - it's merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #218.
Implements a new
strip_preconfiguration option that provides control over how (and if) leading/trailing blank lines are stripped from<pre>tags.The default is
STRIPto strip all leading/trailing blank lines, which represents a change in behavior. (Previous releases did not perform any blank-line removal in<pre>tags.)