Avoid UIPopoverController warning on iOS 5.1.#65
Open
hborders wants to merge 1 commit intomattgemmell:masterfrom
Open
Avoid UIPopoverController warning on iOS 5.1.#65hborders wants to merge 1 commit intomattgemmell:masterfrom
hborders wants to merge 1 commit intomattgemmell:masterfrom
Conversation
On iOS 5.1, passing a CGRectZero here produces this following ominous message: -[UIPopoverController presentPopoverFromRect:inView:permittedArrowDirections:animated:]: the rect passed in to this method must have non-zero width and height. This will be an exception in a future release. This workaround was tested thusly: On iOS 4.3, CGRectZero leaves a popover afterimage before rotation, so does the code below On iOS 5.0, CGRectZero leaves a popover afterimage before rotation, the code below does not On iOS 5.1, CGRectZero leaves a popover afterimage before rotation, so does the code below Basically, this hack performs slightly better than the CGRectZero hack, and does not cause an ominous warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS 5.1, passing a CGRectZero here produces this following ominous message:
-[UIPopoverController presentPopoverFromRect:inView:permittedArrowDirections:animated:]: the rect passed in to this method must have non-zero width and height. This will be an exception in a future release.
This workaround was tested thusly:
On iOS 4.3, CGRectZero leaves a popover afterimage before rotation, so does the code below
On iOS 5.0, CGRectZero leaves a popover afterimage before rotation, the code below does not
On iOS 5.1, CGRectZero leaves a popover afterimage before rotation, so does the code below
Basically, this hack performs slightly better than the CGRectZero hack, and does not cause an ominous warning.