Draft
Conversation
…ented for EnsureExistsStrategy
mattbaird
reviewed
May 27, 2025
| var aI interface{} | ||
| var bI interface{} | ||
| // An e rror will be returned if any of the two documents are invalid. | ||
| func CreatePatch(a, b []byte, collections Collections, strategy PatchStrategy) ([]JsonPatchOperation, error) { |
Owner
There was a problem hiding this comment.
is there a way to retain the original API CreatePatch call with intelligent defaults so as to not break all current users?
Author
There was a problem hiding this comment.
Sorry, I should have opened this in draft mode as this is really not ready yet.
To your point, yes, if there is a desire to merge this back in, we could make the strategy default to PatchStrategyExactMatch, which is what the current implementation does. The only thing I'd need to think through a bit is the collection handling, because for our use case, we default to set semantics, while the original implementation defaults to array semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.