Fix data branch decimal results on main#24894
Open
gouhongshen wants to merge 7 commits into
Open
Conversation
53ecf84 to
0903902
Compare
Contributor
Author
|
Updated this PR to address the review coverage gaps. Covered in this push:
Local validation on
Re-requesting review. |
Contributor
Author
|
已把 3.0-dev 上处理 change request 的 decimal256 data branch pick 修复 port 到 main。 本次更新 commit: 本地验证: source $HOME/.zshrc && cd /Users/ghs-mo/MOWorkSpace/matrixone-2nd && moenv && cd /private/tmp/matrixone-port-decimal-main && go test ./pkg/container/types ./pkg/container/vector ./pkg/frontend ./pkg/sql/colexec/lockop ./pkg/vm/engine/readutil ./pkg/objectio/mergeutil ./pkg/vm/engine/tae/mergesort -run 'TestSimpleTupleAllTypes|TestSingleTypeTuple|TestDecimal256OrderTuple|TestTupleSQLStrings|TestTupleSQLStringsWithEncodeDecode|TestDecodeTupleWithSchema|TestUnpackNthElement|TestType_DescString|TestFetchDecimal256Rows|TestFetchDecimal256RowsWithFilter|TestFetchDecimal256RowsWithFilterAll|TestNumericGap_AllTypes|TestIsNumericType|TestAppendNumericStringToVec_AllTypes|TestCoercePickKeyVectorToType_Decimal256ReformatsToTargetType|TestExtractPKValDecimal256|TestFormatPickKeyVectorValueAsString_AllSupportedKinds|TestLCAProbeJoinCastType|TestConstructBlockPKFilter|TestMergeBaseFilterInKind|TestMergeSortBatchesDecimal256|TestAObjMergeDecimal256' -count=1结果:PASS。 |
(cherry picked from commit e4cb379)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #24847
What this PR does / why we need it:
Port the data branch decimal result conversion fix to
main.diff_14.sqlfor decimal64/decimal128/decimal256data branch diff.Notes:
565a0f71is already present inmainwithtree.WithSingleQuoteString()and unit coverage.Checks:
make -C thirdpartiessource $HOME/.zshrc && moenv && go test ./pkg/container/types ./pkg/frontend ./pkg/vm/engine/disttae/logtailreplaygit diff --check upstream/main...HEADDraft until CI confirms this port on
main.