Add skip_hash=True/False option to allow hash comparison to be skipped for specific tests#260
Open
astrofrog wants to merge 4 commits intomatplotlib:mainfrom
Open
Add skip_hash=True/False option to allow hash comparison to be skipped for specific tests#260astrofrog wants to merge 4 commits intomatplotlib:mainfrom
astrofrog wants to merge 4 commits intomatplotlib:mainfrom
Conversation
…d for cases where hybrid mode is used and a test is not giving deterministic hashes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using pytest-mpl in glue-jupyter for non-matplotlib output (as described/discussed in #201) and I am using hybrid hash/baseline mode. Most of the tests give deterministic hashes, but a couple don't, and it's does not seem possible to fix this. However, the produced figures have an rms difference of <1 so very close to the baseline image.
This PR provides a way to skip hash comparison for specific tests when the hash library is enabled globally. If this is not desirable, I can try and find another solution, but I thought this might be generically useful for other projects.
Full disclaimer: I used a LLM to assist me as part of this PR, but every line here has been either written or reviewed/carefully checked by me